Changes can-route to use pushstate
Read the can-route-pushstate API docs on CanJS.com.
See the latest releases on GitHub.
The contribution guide has information on getting help, reporting bugs, developing locally, and more.
Pushstate for can-route
Home Page: https://canjs.com/doc/can-route-pushstate.html
License: MIT License
Changes can-route to use pushstate
Read the can-route-pushstate API docs on CanJS.com.
See the latest releases on GitHub.
The contribution guide has information on getting help, reporting bugs, developing locally, and more.
1.3.0
to 1.3.2
.This version is covered by your current version range and after updating it in your project the build failed.
can-dom-events is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.
The new version differs by 9 commits.
39d3c16
1.3.2
1e607ff
1.3.1
9f7ef7b
Merge pull request #56 from canjs/ie11-compat
5fdd173
edit append input in one test
efe19b4
fix querySelector in one other place
1181693
edit the test as in the review
635f9cd
fix tests for IE11
9675002
fix linting error
a4e2cd1
edit tests for IE
See the full diff
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot 🌴
Branch | Build failing 🚨 |
---|---|
Dependency | can-globals |
Current Version | 0.3.0 |
Type | dependency |
This version is covered by your current version range and after updating it in your project the build failed.
can-globals is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.
Adds an is-web-worker
module.
The new version differs by 4 commits.
5b18d4a
0.4.0
b4e29bf
Merge pull request #37 from canjs/is-web-worker
843901d
removing build
3ccf558
adds isWebWorker
See the full diff
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot 🌴
This commit should be reverted: f1422b6
…when this issue with highlight.js
gets fixed: highlightjs/highlight.js#1984
1.1.3
to 1.1.4
.This version is covered by your current version range and after updating it in your project the build failed.
can-queues is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot 🌴
These docs don't exist on https://canjs.com/doc/can-route-pushstate.html:
can-route-pushstate/can-route-pushstate.js
Lines 34 to 67 in 104691d
Currently in anchorClickHandler
, if an unhandled exception occurs during state changes, execution breaks before preventDefault
is called. The default behavior of the anchor fires, doing a full navigation / reloading the page.
This resulting situation is pretty tough to debug, so we should instead call preventDefault
as early as possible, rather than as the last thing we do here:
can-route-pushstate/can-route-pushstate.js
Line 202 in 8355950
I'd like to make it so can-route-pushstate
can be a named export. In order to do this, it can not automatically set itself up as the default routing as is done here:
https://github.com/canjs/can-route-pushstate/blob/master/can-route-pushstate.js#L308-L311
Instead, this setup should happen if pushstate
is called:
import {route, routePushstate} from "can";
routePushstate(); // sets itself up as the routing connection
route.data = new AppVM();
route.register(" ... ");
route.start();
Alternatively, we could make it work with the stuff @chasenlehara is working on a little more clearly:
import {route, routePushstate} from "can";
route.register(" ... ");
// bind would replace .start()
// it would effectively setup the two-way binding between route.data
route.bind(new AppVM(), routePushstate );
We could create a hash one that does the same thing:
import {route, routeHash} from "can";
route.register(" ... ");
// bind would replace .start()
// it would effectively setup the two-way binding between route.data
route.bind(new AppVM(), routeHash );
import route from "can-route-pushstate";
route.bindings.pushstate.root = "public/";
route.register("/", { moduleId: "component-1" });
route.register("/component-2", { moduleId: "component-2" });
when I visit http://127.0.0.1:8081/public/
in the browser, I get redirected to http://127.0.0.1:8081/public/public/public
.
Adding a leading slash to pushtate.root
fixes the issue
route.bindings.pushstate.root = "/public/"; // works!
should the leading slash be inserted automagically?
Branch | Build failing 🚨 |
---|---|
Dependency | steal |
Current Version | 1.5.13 |
Type | devDependency |
This version is covered by your current version range and after updating it in your project the build failed.
As steal is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.
I recommend you give this issue a high priority. I’m sure you can resolve this 💪
This patch release fixes the following issues:
map
is not being set properly #1208The new version differs by 14 commits.
fd74d20
1.5.14
de374a1
Merge pull request #1273 from stealjs/loads-twice-warning
9889943
Use Function::bind instead of console.warn.bind
e6dfcb2
Warn if a module is loaded at the same path twice
38d9835
Merge pull request #1271 from stealjs/map-right
d548dd8
Apply mappings when left-side is not a pkg but right-side is.
cc8ad7d
Merge pull request #1211 from stealjs/map-right
c61222b
Add missing import
4c7da96
Use Node 7 for tests
c0ff9eb
Restructure npm normalize tests
d0b771b
Merge pull request #1270 from stealjs/update-guide
e15e2e4
Show full package.json content with diff
4f35064
Add plugins configuration documentation
cd6cd0b
NPM -> npm
See the full diff
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴
☝️ Greenkeeper’s updated Terms of Service will come into effect on April 6th, 2018.
Branch | Build failing 🚨 |
---|---|
Dependency | steal-tools |
Current Version | 1.11.4 |
Type | devDependency |
This version is covered by your current version range and after updating it in your project the build failed.
steal-tools is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.
This is a patch release, fixing an issue where stealTools.export()
ed modules were throwing when run within Node.js
The new version differs by 3 commits.
4a8d7c0
1.11.5
dd10ef3
Merge pull request #953 from stealjs/export-node
0f5a904
Allow global exports to run in Node
See the full diff
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot 🌴
Branch | Build failing 🚨 |
---|---|
Dependency | can-util |
Current Version | 3.10.8 |
Type | dependency |
This version is covered by your current version range and after updating it in your project the build failed.
can-util is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪
The new version differs by 9 commits.
9e008ba
Update dist for release
24168c1
Merge pull request #349 from canjs/upgrade-can-globals
b4326d5
Upgrade to can-globals 0.2.1
51ea1fc
Merge pull request #353 from canjs/deprecate-can-cid-map-and-set
fce3514
Deprecate cid-map and cid-set
d184050
Merge pull request #350 from canjs/deprecate-dom/data/core
43eec95
Fixing Sauce Labs badge
5900a0d
adding Sauce Labs badge
01fd613
Deprecate dom/data/core in favor of can-dom-data-state
See the full diff
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴
When following following tbe deep-dive guide for donejs, and loading your page using the following in console log in app.js (with the same deep dive index.stache
):
get pageComponent () {
console.log('this.routeData', this.routeData)
...
}
In the browser console the above always works, but in SSR (and before detaching in the browser window) and the log in the terminal, it is often an empty object causing a 404 page to show as that is the default in the switch. The only time the default switch isn't executed but the object in terminal is still empty is when the default for the route matches what was called.
route.register('{page}', { page: 'home' })
Not sure how to debug this further, but I am willing to spend time debugging this.
These were added in canjs/canjs#1467, but were never documented.
4.4.6
to 4.4.7
.This version is covered by your current version range and after updating it in your project the build failed.
can-route is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.
The new version differs by 10 commits.
a59492c
4.4.7
d627e8d
Merge pull request #229 from canjs/chasenlehara-patch-1
050ef99
Fix the deprecated group’s name in the docs
d9a249b
Merge pull request #225 from canjs/greenkeeper/testee-0.9.0
70473b6
Merge pull request #226 from canjs/landscaper/update-default-repos
a1f3694
Update readme.md
bdfc465
Update README generated by DoneJS
a78deb9
chore(package): update testee to version 0.9.0
7ac7f86
Merge pull request #218 from canjs/greenkeeper/done-serve-3.0.0
10f0055
chore(package): update done-serve to version 3.0.0
See the full diff
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot 🌴
Branch | Build failing 🚨 |
---|---|
Dependency | can-queues |
Current Version | 1.1.0 |
Type | dependency |
This version is covered by your current version range and after updating it in your project the build failed.
can-queues is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.
The new version differs by 4 commits.
8c136f8
1.1.1
59534cf
don't publish docs
404f62b
Merge pull request #17 from canjs/fix-webpack-debug-style
b38752f
fix dev code for webpack compatibility
See the full diff
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot 🌴
this.keepHash
was added in response to #95, to make keepHash default to true.
The same functionality was previously with includeHash
, which defaulted to false: d8fdbf1.
I believe this.keepHash
can be removed.
true
. We always want to keep the hash when setting the URL.var canReflect = require('can-reflect');
var route = require('can-route-pushtate');
route.register("");
route.register("{page}");
route.start();
var obs = new Observation(function() {
return route.currentRule();
});
canReflect.onValue(function(newRule) {
// not working =(
});
window.pushState(null, null, "home");
I think that Pushstate
should work independent of can-route
, but it does not. For example, a codepen like this does not work:
https://codepen.io/justinbmeyer/pen/MzGyPb?editors=1011
This is because:
Pushstate
calls into can-route
to know the root
(which is going to be #!)if (route.rule(url) !== undefined) {
#1
can be solved by letting people pass the "root"
into new RoutePushstate()
.
#2
is tricker. We could allow people to pass in if the "url" should be handled.
new RoutePushstate({
root: "/",
usePushstate(){
return true; // All links will use pushstate
}
})
I think we should enable this sort of flexibility now. It will make issues like canjs/canjs#4448 easier to tackle.
For backwards compatibility, we will just make the constructor default to:
new RoutePushstate({
root: function(){
bindingProxy.call("root")
},
usePushstate(){
return true; // All links will use pushstate
}
})
The other place it is used is when setting the value of the observable (obs.set("/some/url")
).
Currently, set(){}
uses route.deparam()
to diff which keys are changing and optionally call replaceState
instead of pushState
.
Do we need this functionality? Should we expect people to call these themselves? We could have additional configuration like:
new RoutePushstate({
historyMethod(path) {
return CHECK_PATH ? "pushState" : "replaceState"
}
})
2.6.2
to 2.6.3
.This version is covered by your current version range and after updating it in your project the build failed.
can-define is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.
The new version differs by 13 commits.
150aa1f
2.6.3
ba24d71
Merge pull request #394 from canjs/393-retain-getter
f76a0f3
#393 able to delete a key
e845796
Merge pull request #386 from canjs/ie11-configurable
a942593
Fix linting errors
9f63570
remove debugger statement
292f368
Work around a hilariously bad enumeration bug
ed22618
Update test for IE
6fabf47
Make more properties configurable
0014f99
Do not use iterables in Set constructor
79a6c98
Merge branch 'master' into ie11-configurable
edb2105
Add configurable to map events as well
2e46c6a
Fix for IE11 issues
See the full diff
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot 🌴
This is for compatibility with the latest nw.js versions, which use the chrome-extension:
protocol rather than file:
Branch | Build failing 🚨 |
---|---|
Dependency | can-define |
Current Version | 1.4.3 |
Type | devDependency |
This version is covered by your current version range and after updating it in your project the build failed.
As can-define is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.
I recommend you give this issue a high priority. I’m sure you can resolve this 💪
The new version differs by 18 commits.
af17448
Update dist for release
89f031f
Merge pull request #259 from canjs/bg-update-warning
cce5b90
Add second test case for value assigned to a constructor
3bf43ab
Update to give warning if value is set to a constructor
21787bb
Merge pull request #256 from canjs/202-warn-on-ignored-set
c3df182
Fix warning tests based on other merged PRs
82e9f37
Merge branch 'master' into 202-warn-on-ignored-set
f51e93a
Merge pull request #258 from canjs/bg-warn-148
0c389d4
Merge pull request #257 from canjs/205-warn-on-constructor-for-type
8b0fb11
Update warning message
97f89bd
Improve warning message for get-with-no-set condition
292b1a5
Move test to map/map-test.js
eeb2aab
Guard dev warning test behind System.env check
152705e
Warns when value property is assigned an object. Resolves #148
1448610
Warn when a constructor is supplied as a type definition (likely should be a Type) (#205)
There are 18 commits in total.
See the full diff
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴
It's because it is using the wrong method:
can-route-pushstate/can-route-pushstate.js
Line 226 in a08dfe3
The docs mention that the pushstate plugin is available at route.pushstate
, but after this commit it is instead route.bindings.pushstate
. (It might have been like this before, I didn't really dig to find out).
At least the docs for root
need to be updated: https://canjs.com/doc/can-route-pushstate.root.html.
The anchorClickHandler function fails when clicking on anchor tags in svg. e.g.
<a xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="/things/1/description">
<rect x="432.5" y="20" width="50" height="130" class="transponder"></rect>
</a>
It looks like the property pathname does not exist for svg anchor tags so this causes line 186 in v3.2.3 to fail. The equivalent property in SVG anchor tags looks like it is called baseURI
I'm not sure if canJS is supposed to support SVG but anyway, I thought I would raise this. I can of course, change the route in a function, but it seemed like an interesting thing to note.
From this convo: https://gitter.im/donejs/donejs?at=5b042cf7d332ee5fad3b3b3e
It is strange that this works:
route.urlData = new RoutePushstate();
route.urlData.root = "/filemanager/";
...but this doesn't:
route.urlData = new RoutePushstate({ root: "/filemanager/" });
From: canjs/canjs#1492
Branch | Build failing 🚨 |
---|---|
Dependency | can-util |
Current Version | 3.9.3 |
Type | dependency |
This version is covered by your current version range and after updating it in your project the build failed.
can-util is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪
The new version differs by 3 commits.
1d9a914
Update dist for release
31a45d1
Merge pull request #299 from canjs/294-disabled-events-fix
52fce14
ignore disabled element warning at feature detection
See the full diff
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴
Branch | Build failing 🚨 |
---|---|
Dependency |
[can-reflect](https://github.com/canjs/can-reflect)
|
Current Version | 1.16.3 |
Type | dependency |
This version is covered by your current version range and after updating it in your project the build failed.
can-reflect is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.
The new version differs by 9 commits.
8bdfbe1
Update dist for release
2f69d04
Merge pull request #117 from canjs/116-haskey-primitives
aa89ed5
fixes IE9 and 10
5d463c2
fixes IE11's lack of Object.getPrototypeOf working on primitives
4754791
Fixes issue with hasKey not working on primitives
56ae882
fixing undefined check
221c5f4
Merge pull request #114 from Aosanders/master
9ebeadf
added undefined and null support fixes #105
ca389b5
splice fix training fixes #112
See the full diff
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot 🌴
Branch | Build failing 🚨 |
---|---|
Dependency | steal-tools |
Current Version | 1.3.3 |
Type | devDependency |
This version is covered by your current version range and after updating it in your project the build failed.
As steal-tools is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.
I recommend you give this issue a high priority. I’m sure you can resolve this 💪
This patch release includes fixes for the following issues:
dest
does not support function for CJS output #683url()
s when using bundles #689💥 💥
The new version differs by 30 commits.
0b7a0b9
1.3.4
d1ddfed
Merge pull request #709 from stealjs/ignore-uglify
0dad54e
Merge pull request #713 from stealjs/export-stuff
96f1248
Adds buildResult as resolved value for stealTools.export
a556a9a
Set greenkeeper to ignore uglify-js
9e6a405
Merge pull request #704 from stealjs/pump
a94d072
Merge pull request #705 from stealjs/bundle-docs
dc1d31f
Fix steal-tools bundle docs
d39524d
Simplify steal-tools bundle with pump library
fea3bd9
Merge pull request #703 from stealjs/pump
b0697e0
Use pump library in steal-tools build code
d461624
Merge pull request #685 from stealjs/conditional-with-extensions
7edd2c3
Use [email protected]
b7e1702
Merge pull request #694 from stealjs/greenkeeper/yargs-8.0.1
060d751
Merge pull request #697 from stealjs/pYr0x-patch-1
There are 30 commits in total.
See the full diff
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴
#16 is failing because it is expecting route.attr()
to return a route
property. This was changed to be a separate matched
compute with canjs/can-route#34.
2.2.0
to 2.3.0
.This version is covered by your current version range and after updating it in your project the build failed.
can-simple-observable is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.
This adds .value
getter and setters for Async/Resolver/Settable/Setter and SimpleObservable:
obs = new SimpleObservable(5); obs.value // ->5obs.value = 3;
obs.value // -> 3
The new version differs by 4 commits.
f456b02
2.3.0
8fae622
adds .value for canjs/can-value#19
85e3a31
Merge pull request #34 from canjs/ie11-compat
ac50344
Do not call Map/Set directly with iterables
See the full diff
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot 🌴
Branch | Build failing 🚨 |
---|---|
Dependency | steal |
Current Version | 1.5.4 |
Type | devDependency |
This version is covered by your current version range and after updating it in your project the build failed.
As steal is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.
I recommend you give this issue a high priority. I’m sure you can resolve this 💪
The new version differs by 7 commits.
f988df2
1.5.5
5e35152
Merge pull request #1222 from stealjs/1221-dynamic-clones
65abac0
fixes #1221 and adds tests for it
5ef2d0d
shows problem doesn't require dynamic imports
245739b
demonstrates error with #1221
115a8f0
Merge pull request #1215 from stealjs/greenkeeper/testee-0.5.1
a48415c
chore(package): update testee to version 0.5.1
See the full diff
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴
Given a template like this:
<a href="#hash-in-the-url">Link</a>
<p id="hash-in-the-url">Target</p>
…and some CSS:
p:target {background: yellow;}
…and some JS:
import route from 'can-route';
import 'can-route-pushstate';
route('/{page}', { page: 'home' });
One would expect that clicking on the link would cause the paragraph to light up yellow, when unfortunately preventDefault()
gets called on the event:
can-route-pushstate/can-route-pushstate.js
Lines 187 to 198 in 040e3e1
Should be able to use books/{genre}/{author}"
syntax added in canjs/can-route#18.
Branch | Build failing 🚨 |
---|---|
Dependency | steal-tools |
Current Version | 1.8.4 |
Type | devDependency |
This version is covered by your current version range and after updating it in your project the build failed.
As steal-tools is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.
I recommend you give this issue a high priority. I’m sure you can resolve this 💪
Along with being able to use steal-conditional in optimized builds, this release includes fixes for the following issues:
@loader
not defined in slim build #856@steal
in optimized builds #849Thanks to @pYr0x for adding support to bundleAssets
in optimized builds and filing a bunch of other issues.
💥 🎊
The new version differs by 45 commits.
b6da933
1.9.0
c036da2
Merge pull request #864 from stealjs/uglify-sourcemaps
1c2fa5d
Improve minified code sourcemaps
99a0eb0
Merge pull request #848 from stealjs/serviveworker
ceb089d
remove integrated serviceworker plugin
157f96d
Merge branch 'master' into serviveworker
0abee93
Merge pull request #859 from stealjs/no-pluck
2e8b957
Stop plucking @loader from graph in optimized builds
2b6be8e
Merge pull request #858 from stealjs/deep-clone
e9fc68d
Remove unused import
b7a2962
Do not deep clone bundles
39f58ee
Do not deep clone the graph and loader objects
34fe1cf
Merge pull request #853 from stealjs/module
137a64e
Support AMD "module" import in slim builds
072cbf2
Merge pull request #850 from stealjs/add-at-steal
There are 45 commits in total.
See the full diff
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴
Branch | Build failing 🚨 |
---|---|
Dependency | can-route |
Current Version | 3.0.11 |
Type | dependency |
This version is covered by your current version range and after updating it in your project the build failed.
can-route is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪
The new version differs by 6 commits.
0b3bd0a
Update dist for release
036d204
fixing postversion script
f092d27
Do Not Merge - can-reflect (#81)
7062ef3
Merge pull request #74 from canjs/add-app-state-example
1d1e244
Update can-route.md
0a526aa
Added setting AppSate example related to canjs/canjs/3208
See the full diff
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴
Branch | Build failing 🚨 |
---|---|
Dependency | can-util |
Current Version | 3.10.15 |
Type | dependency |
This version is covered by your current version range and after updating it in your project the build failed.
can-util is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.
such as the enter
event
The new version differs by 4 commits.
7e8669a
Update dist for release
d8aa612
Update dist for release
f36c036
Merge pull request #392 from canjs/390-enter-event
70f81b4
Closes #390 - make delegated custom events work
See the full diff
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot 🌴
Branch | Build failing 🚨 |
---|---|
Dependency | can-map |
Current Version | 3.0.7 |
Type | devDependency |
This version is covered by your current version range and after updating it in your project the build failed.
As can-map is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.
I recommend you give this issue a high priority. I’m sure you can resolve this 💪
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴
Note: we are upgrading our app to the latest and greatest.
The anchor click handler is no longer working - expected "route" property is no longer there. Here is the condition which no longer passes:
https://github.com/canjs/can-route-pushstate/blob/v4.0.0-pre.6/can-route-pushstate.js#L171
For reference, the older version of can-route.deparam
included a .route
property if a route was matched:
https://github.com/canjs/can-route/blob/master/can-route.js#L548
... this seems to be missing from the new code:
https://github.com/canjs/can-route/blob/v4.0.1-0/src/deparam.js#L126
@signature
(s)@signature
(s)replaceStateOff
replaceStateOnce
replaceStateOn
.value
for RoutePushstate
.mock-url
like import to aptly show how can-route-pushstate works.Currently we store the location
object in a variable. This prevents it from being changed in SSR for each request. We should lazily retrieve the location object like we do for the document and global elsewhere in canjs.
Branch | Build failing 🚨 |
---|---|
Dependency | can-event |
Current Version | 3.4.0 |
Type | dependency |
This version is covered by your current version range and after updating it in your project the build failed.
can-event is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪
The new version differs by 3 commits.
8a37dd8
Update dist for release
d4f5f74
fixing postversion script
7c28fce
Do Not Merge - can-reflect (#56)
See the full diff
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴
Branch | Build failing 🚨 |
---|---|
Dependency | can-define |
Current Version | 1.0.26 |
Type | devDependency |
This version is covered by your current version range and after updating it in your project the build failed.
As can-define is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.
I recommend you give this issue a high priority. I’m sure you can resolve this 💪
The new version differs by 13 commits.
26d4b30
Update dist for release
3fdaa23
fixing postversion script
1707547
getting tests to pass with reflect apis (#165)
826461d
Merge pull request #212 from canjs/fix-qunit-ok
4d07c86
Merge pull request #189 from canjs/dont-redefine-data
34f0854
Replaced QUnit.ok with QUnit.equal
34b8f5c
Fixing the incorrect use of QUnit.ok
18531dd
Merge remote-tracking branch 'origin/master' into dont-redefine-data
e3c3858
Make tests work on all supported platforms, including unrelated IE issue
fbf76d1
fix jshint error
b2c10a8
fix jshint error
9715a88
Add test to show that sealed objects are still not extensible
f023cbc
Don't attempt to redefine _data or _computed on DefineMaps if they're already defined
See the full diff
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴
Issued discovered here canjs/bit-docs-html-canjs#205
It registers itself as binding on route, intercepts click events on elements across document and accordingly updates route state and window’s pathname.
Avoid it
and indefinite pronouns. This should say something like https://github.com/canjs/can-route-pushstate/pull/128/files#diff-6ff0cfe12a8580703c9be3b06a5ee442R329
Also, it should talk about PushStateObservable inheriting from SimpleObservable
and getting most of the "observable" logic from that.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.