Coder Social home page Coder Social logo

canjs / can-route-pushstate Goto Github PK

View Code? Open in Web Editor NEW
8.0 14.0 4.0 724 KB

Pushstate for can-route

Home Page: https://canjs.com/doc/can-route-pushstate.html

License: MIT License

JavaScript 90.32% HTML 9.00% Makefile 0.68%
pushstate route-pushstate pushstate-routing

can-route-pushstate's Introduction

can-route-pushstate's People

Contributors

andrejewski avatar bmomberger-bitovi avatar chasenlehara avatar cherifgsoul avatar christopherjbaker avatar daffl avatar garrettreed avatar greenkeeper[bot] avatar greenkeeperio-bot avatar imaustink avatar indifferentghost avatar justinbmeyer avatar m-mujica avatar macrofig avatar matthewp avatar mikedane avatar nlundquist avatar phillipskevin avatar qirui-sun-tc avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

can-route-pushstate's Issues

An in-range update of can-dom-events is breaking the build 🚨

The dependency can-dom-events was updated from 1.3.0 to 1.3.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

can-dom-events is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

Commits

The new version differs by 9 commits.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of can-globals is breaking the build 🚨

Version 0.4.0 of can-globals was just published.

Branch Build failing 🚨
Dependency can-globals
Current Version 0.3.0
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

can-globals is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Release Notes is-web-worker

Adds an is-web-worker module.

Commits

The new version differs by 4 commits.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of can-queues is breaking the build 🚨

The dependency can-queues was updated from 1.1.3 to 1.1.4.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

can-queues is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

Commits

The new version differs by 3 commits.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Some docs are not showing up

These docs don't exist on https://canjs.com/doc/can-route-pushstate.html:

/**
* @property {String} route.pushstate.root
* @parent route.pushstate
*
* @description Configure the base url that will not be modified.
*
* @option {String} Represents the base url that pushstate will prepend to all
* routes. `root` defaults to: `"/"`.
*
* @body
*
* ## Use
*
* By default, a route like:
*
* route(":type/:id")
*
* Matches urls like:
*
* http://domain.com/contact/5
*
* But sometimes, you only want to match pages within a certain directory. For
* example, an application that is a filemanager. You might want to
* specify root and routes like:
*
* route.pushstate.root = "/filemanager/"
* route("file-:fileId");
* route("folder-:fileId")
*
* Which matches urls like:
*
* http://domain.com/filemanager/file-34234
*
*/

anchorClickHandler should preventDefault earlier

Currently in anchorClickHandler, if an unhandled exception occurs during state changes, execution breaks before preventDefault is called. The default behavior of the anchor fires, doing a full navigation / reloading the page.

This resulting situation is pretty tough to debug, so we should instead call preventDefault as early as possible, rather than as the last thing we do here:

if (shouldCallPreventDefault && e.preventDefault) {

can-route-pushstate should be exportable as a named export

I'd like to make it so can-route-pushstate can be a named export. In order to do this, it can not automatically set itself up as the default routing as is done here:

https://github.com/canjs/can-route-pushstate/blob/master/can-route-pushstate.js#L308-L311

Instead, this setup should happen if pushstate is called:

import {route, routePushstate} from "can";


routePushstate(); // sets itself up as the routing connection

route.data = new AppVM();
route.register(" ... ");
route.start();

Alternatively, we could make it work with the stuff @chasenlehara is working on a little more clearly:

import {route, routePushstate} from "can";

route.register(" ... ");

// bind would replace .start()
// it would effectively setup the two-way binding between route.data
route.bind(new AppVM(), routePushstate ); 

We could create a hash one that does the same thing:

import {route, routeHash} from "can";

route.register(" ... ");

// bind would replace .start()
// it would effectively setup the two-way binding between route.data
route.bind(new AppVM(), routeHash ); 

Strange behavior when root does not have leading slash

import route from "can-route-pushstate";

route.bindings.pushstate.root = "public/";
route.register("/", { moduleId: "component-1" });
route.register("/component-2", { moduleId: "component-2" });

when I visit http://127.0.0.1:8081/public/ in the browser, I get redirected to http://127.0.0.1:8081/public/public/public.

Adding a leading slash to pushtate.root fixes the issue

route.bindings.pushstate.root = "/public/";  // works!

should the leading slash be inserted automagically?

An in-range update of steal is breaking the build 🚨

Version 1.5.14 of steal just got published.

Branch Build failing 🚨
Dependency steal
Current Version 1.5.13
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As steal is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details
  • continuous-integration/travis-ci/push The Travis CI build failed Details

Release Notes 1.5.14

This patch release fixes the following issues:

  • Missing docs for plugin configuration stealjs/stealjs#34
  • Show full package.json content in progressive loading guide #1267
  • npm config map is not being set properly #1208
  • Warn if someone loaded a module at the same path twice #1264
Commits

The new version differs by 14 commits.

  • fd74d20 1.5.14
  • de374a1 Merge pull request #1273 from stealjs/loads-twice-warning
  • 9889943 Use Function::bind instead of console.warn.bind
  • e6dfcb2 Warn if a module is loaded at the same path twice
  • 38d9835 Merge pull request #1271 from stealjs/map-right
  • d548dd8 Apply mappings when left-side is not a pkg but right-side is.
  • cc8ad7d Merge pull request #1211 from stealjs/map-right
  • c61222b Add missing import
  • 4c7da96 Use Node 7 for tests
  • c0ff9eb Restructure npm normalize tests
  • d0b771b Merge pull request #1270 from stealjs/update-guide
  • e15e2e4 Show full package.json content with diff
  • 4f35064 Add plugins configuration documentation
  • cd6cd0b NPM -> npm

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

An in-range update of steal-tools is breaking the build 🚨

☝️ Greenkeeper’s updated Terms of Service will come into effect on April 6th, 2018.

Version 1.11.5 of steal-tools was just published.

Branch Build failing 🚨
Dependency steal-tools
Current Version 1.11.4
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

steal-tools is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Release Notes 1.11.5

This is a patch release, fixing an issue where stealTools.export()ed modules were throwing when run within Node.js

Commits

The new version differs by 3 commits.

  • 4a8d7c0 1.11.5
  • dd10ef3 Merge pull request #953 from stealjs/export-node
  • 0f5a904 Allow global exports to run in Node

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of can-util is breaking the build 🚨

Version 3.10.9 of can-util just got published.

Branch Build failing 🚨
Dependency can-util
Current Version 3.10.8
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

can-util is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪

Status Details
  • continuous-integration/travis-ci/push The Travis CI build failed Details

Commits

The new version differs by 9 commits.

  • 9e008ba Update dist for release
  • 24168c1 Merge pull request #349 from canjs/upgrade-can-globals
  • b4326d5 Upgrade to can-globals 0.2.1
  • 51ea1fc Merge pull request #353 from canjs/deprecate-can-cid-map-and-set
  • fce3514 Deprecate cid-map and cid-set
  • d184050 Merge pull request #350 from canjs/deprecate-dom/data/core
  • 43eec95 Fixing Sauce Labs badge
  • 5900a0d adding Sauce Labs badge
  • 01fd613 Deprecate dom/data/core in favor of can-dom-data-state

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

When used with SSR

When following following tbe deep-dive guide for donejs, and loading your page using the following in console log in app.js (with the same deep dive index.stache):

  get pageComponent () {
    console.log('this.routeData', this.routeData)
    ...
  }

In the browser console the above always works, but in SSR (and before detaching in the browser window) and the log in the terminal, it is often an empty object causing a 404 page to show as that is the default in the switch. The only time the default switch isn't executed but the object in terminal is still empty is when the default for the route matches what was called.

route.register('{page}', { page: 'home' })

Not sure how to debug this further, but I am willing to spend time debugging this.

An in-range update of can-route is breaking the build 🚨

The dependency can-route was updated from 4.4.6 to 4.4.7.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

can-route is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

Commits

The new version differs by 10 commits.

  • a59492c 4.4.7
  • d627e8d Merge pull request #229 from canjs/chasenlehara-patch-1
  • 050ef99 Fix the deprecated group’s name in the docs
  • d9a249b Merge pull request #225 from canjs/greenkeeper/testee-0.9.0
  • 70473b6 Merge pull request #226 from canjs/landscaper/update-default-repos
  • a1f3694 Update readme.md
  • bdfc465 Update README generated by DoneJS
  • a78deb9 chore(package): update testee to version 0.9.0
  • 7ac7f86 Merge pull request #218 from canjs/greenkeeper/done-serve-3.0.0
  • 10f0055 chore(package): update done-serve to version 3.0.0

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of can-queues is breaking the build 🚨

Version 1.1.1 of can-queues was just published.

Branch Build failing 🚨
Dependency can-queues
Current Version 1.1.0
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

can-queues is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Commits

The new version differs by 4 commits.

  • 8c136f8 1.1.1
  • 59534cf don't publish docs
  • 404f62b Merge pull request #17 from canjs/fix-webpack-debug-style
  • b38752f fix dev code for webpack compatibility

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Removal of keepHash.

this.keepHash was added in response to #95, to make keepHash default to true.
The same functionality was previously with includeHash, which defaulted to false: d8fdbf1.

I believe this.keepHash can be removed.

  • There is no documentation pointing to the use of this.keepHash as a feature.
  • At the moment there's never a time it's not true. We always want to keep the hash when setting the URL.

currentRule cannot be observed

var canReflect = require('can-reflect');
var route = require('can-route-pushtate');

route.register("");
route.register("{page}");
route.start();

var obs = new Observation(function() {
  return route.currentRule();
});

canReflect.onValue(function(newRule) {
   // not working =(
});

window.pushState(null, null, "home");

The Pushstate constructor should work independent of can-route

I think that Pushstate should work independent of can-route, but it does not. For example, a codepen like this does not work:

https://codepen.io/justinbmeyer/pen/MzGyPb?editors=1011

This is because:

  1. Pushstate calls into can-route to know the root (which is going to be #!)
  2. When a link is clicked on, the routing rules are checked: if (route.rule(url) !== undefined) {

#1 can be solved by letting people pass the "root" into new RoutePushstate().

#2 is tricker. We could allow people to pass in if the "url" should be handled.

new RoutePushstate({
  root: "/",
  usePushstate(){
    return true; // All links will use pushstate
  }
})

I think we should enable this sort of flexibility now. It will make issues like canjs/canjs#4448 easier to tackle.

For backwards compatibility, we will just make the constructor default to:

new RoutePushstate({
  root: function(){
    bindingProxy.call("root")
  },
  usePushstate(){
    return true; // All links will use pushstate
  }
})

The other place it is used is when setting the value of the observable (obs.set("/some/url")).

Currently, set(){} uses route.deparam() to diff which keys are changing and optionally call replaceState instead of pushState.

Do we need this functionality? Should we expect people to call these themselves? We could have additional configuration like:

new RoutePushstate({
  historyMethod(path) {
    return CHECK_PATH ? "pushState" : "replaceState"
  }
})

An in-range update of can-define is breaking the build 🚨

The devDependency can-define was updated from 2.6.2 to 2.6.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

can-define is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

Commits

The new version differs by 13 commits.

  • 150aa1f 2.6.3
  • ba24d71 Merge pull request #394 from canjs/393-retain-getter
  • f76a0f3 #393 able to delete a key
  • e845796 Merge pull request #386 from canjs/ie11-configurable
  • a942593 Fix linting errors
  • 9f63570 remove debugger statement
  • 292f368 Work around a hilariously bad enumeration bug
  • ed22618 Update test for IE
  • 6fabf47 Make more properties configurable
  • 0014f99 Do not use iterables in Set constructor
  • 79a6c98 Merge branch 'master' into ie11-configurable
  • edb2105 Add configurable to map events as well
  • 2e46c6a Fix for IE11 issues

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of can-define is breaking the build 🚨

Version 1.4.4 of can-define just got published.

Branch Build failing 🚨
Dependency can-define
Current Version 1.4.3
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As can-define is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details
  • continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Commits

The new version differs by 18 commits.

  • af17448 Update dist for release
  • 89f031f Merge pull request #259 from canjs/bg-update-warning
  • cce5b90 Add second test case for value assigned to a constructor
  • 3bf43ab Update to give warning if value is set to a constructor
  • 21787bb Merge pull request #256 from canjs/202-warn-on-ignored-set
  • c3df182 Fix warning tests based on other merged PRs
  • 82e9f37 Merge branch 'master' into 202-warn-on-ignored-set
  • f51e93a Merge pull request #258 from canjs/bg-warn-148
  • 0c389d4 Merge pull request #257 from canjs/205-warn-on-constructor-for-type
  • 8b0fb11 Update warning message
  • 97f89bd Improve warning message for get-with-no-set condition
  • 292b1a5 Move test to map/map-test.js
  • eeb2aab Guard dev warning test behind System.env check
  • 152705e Warns when value property is assigned an object. Resolves #148
  • 1448610 Warn when a constructor is supplied as a type definition (likely should be a Type) (#205)

There are 18 commits in total.

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

anchorClickHandler fails on svg anchor tags

The anchorClickHandler function fails when clicking on anchor tags in svg. e.g.

<a xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="/things/1/description">
   <rect x="432.5" y="20" width="50" height="130" class="transponder"></rect>
</a>

It looks like the property pathname does not exist for svg anchor tags so this causes line 186 in v3.2.3 to fail. The equivalent property in SVG anchor tags looks like it is called baseURI

I'm not sure if canJS is supposed to support SVG but anyway, I thought I would raise this. I can of course, change the route in a function, but it seemed like an interesting thing to note.

An in-range update of can-util is breaking the build 🚨

Version 3.9.4 of can-util just got published.

Branch Build failing 🚨
Dependency can-util
Current Version 3.9.3
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

can-util is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪

Status Details
  • continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Commits

The new version differs by 3 commits.

  • 1d9a914 Update dist for release
  • 31a45d1 Merge pull request #299 from canjs/294-disabled-events-fix
  • 52fce14 ignore disabled element warning at feature detection

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

An in-range update of can-reflect is breaking the build 🚨

Version 1.16.4 of can-reflect was just published.

Branch Build failing 🚨
Dependency [can-reflect](https://github.com/canjs/can-reflect)
Current Version 1.16.3
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

can-reflect is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Commits

The new version differs by 9 commits.

  • 8bdfbe1 Update dist for release
  • 2f69d04 Merge pull request #117 from canjs/116-haskey-primitives
  • aa89ed5 fixes IE9 and 10
  • 5d463c2 fixes IE11's lack of Object.getPrototypeOf working on primitives
  • 4754791 Fixes issue with hasKey not working on primitives
  • 56ae882 fixing undefined check
  • 221c5f4 Merge pull request #114 from Aosanders/master
  • 9ebeadf added undefined and null support fixes #105
  • ca389b5 splice fix training fixes #112

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of steal-tools is breaking the build 🚨

Version 1.3.4 of steal-tools just got published.

Branch Build failing 🚨
Dependency steal-tools
Current Version 1.3.3
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As steal-tools is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details
  • continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Release Notes 1.3.4

This patch release includes fixes for the following issues:

  • Option dest does not support function for CJS output #683
  • Minify the JS bundles (besides each individual node) #695
  • CleanCSS incorrectly updates url()s when using bundles #689
  • Deprecate engine-dependencies package #687
  • Bumps steal-conditional version to handle module identifiers with extensions #685
  • Documentation issues on the steal-tools bundle page stealjs/steal#1197 and #697
  • Adds buildResult as resolved value for stealTools.export #266
  • Use pump to simplify node streams handling here and here.

💥 💥

Commits

The new version differs by 30 commits.

  • 0b7a0b9 1.3.4
  • d1ddfed Merge pull request #709 from stealjs/ignore-uglify
  • 0dad54e Merge pull request #713 from stealjs/export-stuff
  • 96f1248 Adds buildResult as resolved value for stealTools.export
  • a556a9a Set greenkeeper to ignore uglify-js
  • 9e6a405 Merge pull request #704 from stealjs/pump
  • a94d072 Merge pull request #705 from stealjs/bundle-docs
  • dc1d31f Fix steal-tools bundle docs
  • d39524d Simplify steal-tools bundle with pump library
  • fea3bd9 Merge pull request #703 from stealjs/pump
  • b0697e0 Use pump library in steal-tools build code
  • d461624 Merge pull request #685 from stealjs/conditional-with-extensions
  • 7edd2c3 Use [email protected]
  • b7e1702 Merge pull request #694 from stealjs/greenkeeper/yargs-8.0.1
  • 060d751 Merge pull request #697 from stealjs/pYr0x-patch-1

There are 30 commits in total.

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

An in-range update of can-simple-observable is breaking the build 🚨

The dependency can-simple-observable was updated from 2.2.0 to 2.3.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

can-simple-observable is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

Release Notes for Adds .value getter/ setters

This adds .value getter and setters for Async/Resolver/Settable/Setter and SimpleObservable:

obs = new SimpleObservable(5);
obs.value // ->5

obs.value = 3;
obs.value // -> 3

Commits

The new version differs by 4 commits.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of steal is breaking the build 🚨

Version 1.5.5 of steal just got published.

Branch Build failing 🚨
Dependency steal
Current Version 1.5.4
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As steal is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details
  • continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Release Notes v1.5.5

Patches

  • Chore(package): update testee to version 0.5.1: a48415c
  • Merge pull request #1215 from stealjs/greenkeeper/testee-0.5.1: 115a8f0
  • Demonstrates error with #1221: 245739b
  • Shows problem doesn't require dynamic imports: 5ef2d0d
  • Fixes #1221 and adds tests for it: 65abac0
  • Merge pull request #1222 from stealjs/1221-dynamic-clones: 5e35152
Commits

The new version differs by 7 commits.

  • f988df2 1.5.5
  • 5e35152 Merge pull request #1222 from stealjs/1221-dynamic-clones
  • 65abac0 fixes #1221 and adds tests for it
  • 5ef2d0d shows problem doesn't require dynamic imports
  • 245739b demonstrates error with #1221
  • 115a8f0 Merge pull request #1215 from stealjs/greenkeeper/testee-0.5.1
  • a48415c chore(package): update testee to version 0.5.1

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

:target doesn’t work because preventDefault is called

Given a template like this:

<a href="#hash-in-the-url">Link</a>
<p id="hash-in-the-url">Target</p>

…and some CSS:

p:target {background: yellow;}

…and some JS:

import route from 'can-route';
import 'can-route-pushstate';
route('/{page}', { page: 'home' });

One would expect that clicking on the link would cause the paragraph to light up yellow, when unfortunately preventDefault() gets called on the event:

// If a route matches update the data.
var curParams = route.deparam(url);
if (curParams.hasOwnProperty('route')) {
// Makes it possible to have a link with a hash.
includeHash = true;
window.history.pushState(null, null, node.href);
// Test if you can preventDefault
// our tests can't call .click() b/c this
// freezes phantom.
if (e.preventDefault) {
e.preventDefault();

An in-range update of steal-tools is breaking the build 🚨

Version 1.9.0 of steal-tools just got published.

Branch Build failing 🚨
Dependency steal-tools
Current Version 1.8.4
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As steal-tools is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details
  • continuous-integration/travis-ci/push The Travis CI build failed Details

Release Notes 1.9.0

Support steal-conditional in optimized builds

Along with being able to use steal-conditional in optimized builds, this release includes fixes for the following issues:

  • UglifyJS and sourcemaps #863
  • bundleAssets is not working with optimized builds #846
  • @loader not defined in slim build #856
  • The loader is deeply cloned during optimize build #855
  • Support require("module") in optimized builds #852
  • Support @steal in optimized builds #849
  • Optimized builder does not work for multimain apps #823
  • stealTools.optimize requires the config argument #819

Thanks to @pYr0x for adding support to bundleAssets in optimized builds and filing a bunch of other issues.

💥 🎊

Commits

The new version differs by 45 commits.

  • b6da933 1.9.0
  • c036da2 Merge pull request #864 from stealjs/uglify-sourcemaps
  • 1c2fa5d Improve minified code sourcemaps
  • 99a0eb0 Merge pull request #848 from stealjs/serviveworker
  • ceb089d remove integrated serviceworker plugin
  • 157f96d Merge branch 'master' into serviveworker
  • 0abee93 Merge pull request #859 from stealjs/no-pluck
  • 2e8b957 Stop plucking @loader from graph in optimized builds
  • 2b6be8e Merge pull request #858 from stealjs/deep-clone
  • e9fc68d Remove unused import
  • b7a2962 Do not deep clone bundles
  • 39f58ee Do not deep clone the graph and loader objects
  • 34fe1cf Merge pull request #853 from stealjs/module
  • 137a64e Support AMD "module" import in slim builds
  • 072cbf2 Merge pull request #850 from stealjs/add-at-steal

There are 45 commits in total.

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

An in-range update of can-route is breaking the build 🚨

Version 3.1.0 of can-route just got published.

Branch Build failing 🚨
Dependency can-route
Current Version 3.0.11
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

can-route is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪

Status Details
  • continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Commits

The new version differs by 6 commits.

  • 0b3bd0a Update dist for release
  • 036d204 fixing postversion script
  • f092d27 Do Not Merge - can-reflect (#81)
  • 7062ef3 Merge pull request #74 from canjs/add-app-state-example
  • 1d1e244 Update can-route.md
  • 0a526aa Added setting AppSate example related to canjs/canjs/3208

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

An in-range update of can-util is breaking the build 🚨

Version 3.10.17 of can-util was just published.

Branch Build failing 🚨
Dependency can-util
Current Version 3.10.15
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

can-util is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Release Notes fix delegation of custom events

such as the enter event

Commits

The new version differs by 4 commits.

  • 7e8669a Update dist for release
  • d8aa612 Update dist for release
  • f36c036 Merge pull request #392 from canjs/390-enter-event
  • 70f81b4 Closes #390 - make delegated custom events work

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of can-map is breaking the build 🚨

Version 3.1.0 of can-map just got published.

Branch Build failing 🚨
Dependency can-map
Current Version 3.0.7
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As can-map is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details
  • continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

Anchor click handler relies on `.route` property which is no longer there

Note: we are upgrading our app to the latest and greatest.

The anchor click handler is no longer working - expected "route" property is no longer there. Here is the condition which no longer passes:

https://github.com/canjs/can-route-pushstate/blob/v4.0.0-pre.6/can-route-pushstate.js#L171

For reference, the older version of can-route.deparam included a .route property if a route was matched:

https://github.com/canjs/can-route/blob/master/can-route.js#L548

... this seems to be missing from the new code:

https://github.com/canjs/can-route/blob/v4.0.1-0/src/deparam.js#L126

The location object should be retrieved lazily

Currently we store the location object in a variable. This prevents it from being changed in SSR for each request. We should lazily retrieve the location object like we do for the document and global elsewhere in canjs.

An in-range update of can-event is breaking the build 🚨

Version 3.5.0 of can-event just got published.

Branch Build failing 🚨
Dependency can-event
Current Version 3.4.0
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

can-event is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪

Status Details
  • continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Commits

The new version differs by 3 commits.

  • 8a37dd8 Update dist for release
  • d4f5f74 fixing postversion script
  • 7c28fce Do Not Merge - can-reflect (#56)

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

An in-range update of can-define is breaking the build 🚨

Version 1.2.0 of can-define just got published.

Branch Build failing 🚨
Dependency can-define
Current Version 1.0.26
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As can-define is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details
  • continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Commits

The new version differs by 13 commits.

  • 26d4b30 Update dist for release
  • 3fdaa23 fixing postversion script
  • 1707547 getting tests to pass with reflect apis (#165)
  • 826461d Merge pull request #212 from canjs/fix-qunit-ok
  • 4d07c86 Merge pull request #189 from canjs/dont-redefine-data
  • 34f0854 Replaced QUnit.ok with QUnit.equal
  • 34b8f5c Fixing the incorrect use of QUnit.ok
  • 18531dd Merge remote-tracking branch 'origin/master' into dont-redefine-data
  • e3c3858 Make tests work on all supported platforms, including unrelated IE issue
  • fbf76d1 fix jshint error
  • b2c10a8 fix jshint error
  • 9715a88 Add test to show that sealed objects are still not extensible
  • f023cbc Don't attempt to redefine _data or _computed on DefineMaps if they're already defined

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.