campagnelaboratory / icb-utils Goto Github PK

Hi,

While packaging icb-utils for Debian, I encountered issues with the tests. First, I had to apply the below patch to tell Maven where tests were.
specify_test_path_to_maven.txt

Then I had failing tests:

• The tests testResrouceFinderClasspathFileNoArgsConstructor and testResrouceFinderClasspathFileNullToMultiArgsConstructor failed because the build used Maven and properties of log4j thus weren't in the classpath;
• The method testResrouceExistingFileInDir is, I think, wrongly defined: the comment above it suggests that it expects a null result. I would change its last line to "assertNull(url);";
• The 5 tests in TestIpUtils that expect an UnknownHostException fail because inspecting the source code of validateIpAddress shows this method never throws an UnknownHostException.

Best regards,
Pierre Gruet