cameronbourke / react-async-poll Goto Github PK

To reduce load on the system being polled (and the ones doing the polling), it'd be great to be able to slow down/stop polling while the window is not visible.

This should be feasible using the Page Visibility API which is now implemented in modern browsers.

Suggested changes:

1. asyncPoll now takes a third argument: asyncPoll(intervalDuration, component, hiddenIntervalDuration) where hiddenIntervalDuration is the duration to use when document.visibilityState is hidden.
2. the tricky part is how to behave when document.visibilityState changes. The important edge case here is that if the page is hidden and we have a slow timeout, but then the page becomes visible, we should either poll immediately or wait a little longer and then poll. The airtight way to do this would include storing a this.lastPolled timestamp, so that when document.visibilityState changes, we can set a timeout with the remaining interval according to the currently correct intervalDuration. In some cases (if we switched from a slower interval to a faster interval, and the faster interval says we should have already polled) the new timeout would fire immediately after which we'd settle back in to the regular setInterval situation.

There could also be a simpler approach to this, where whenever document.visibilityState changes, we simply poll right then and then carry on with the appropriate interval.

I think it really cool if we know about the status of polling, e.g.:
this.keepPolling - true or false in current moment

Thank you :)

@cameronbourke @deepakjois @mxstbr

I need to to use the react-async-poll in two different places with different poll intervals. Currently, I have to write two different wrappers with different poll intervals. Can I pass the poll interval as props?

When you want to stop polling and call the "stopPolling" method, your cannot restart it.
The issue comes up because the "interval" property isn't set to undefined (line 29)