cam-ball / steven Goto Github PK

c'mon

calling !display on a Steven-configured user with no permitted actions throws a bad request error and cancels response

readme currently says !addaction [user_id] affirm and !addaction [user_id] haze, when it should actually reverse the parameter order (!addaction affirm [user_id] and !addaction haze [user_id])

might just be broken for the !display command

was definitely resolved once in #22 but it's crept back in

As it is now, a user cannot have statistics isolated to one server, as we only check for user_id and not server_id when querying for users

Steven should reply when someone mentions him

Due to typing quirks and differences in activity levels, some users send a relatively high or low number of messages compared to the average user.
Steven's message triggers should take this into account and seed trigger values relative to the user in question's message rate

README.md is out of date:

• include missing commands
  • !removeaction - This is owner only command
  • !help
  • !display
• include missing event triggers (in the 'hooks' section of the readme)
  • mentions

CONTRIBUTING.md is out of date:

• New branches should be created from develop
• Ready to review branches should be up to date with develop
• Remove label part step

ENV variables set in Travis settings do not apply to forks, and with the current configuration I would need to expose my personal testing keys.

Possible solutions to investigate include:

• finding a way to encrypt env variables even for forks
• finding a way to run tests with an invalid discord token
• something else v sexy and exciting

requested that the CI step in the contribution guide be removed for now in #50

Add ability to remove an action type for a user.
Syntax should be !removeaction [user_id] [action]

This should be an owner-only command

The current implementation to locate a user will assume that input is a User ID if the argument is an integer. However, it is possible to have integer usernames.

When the provided user information is an integer and a search by ID does not return any information, the bot should search by username before failing.

Just like the affirmations list, the haze list will house insults to be lobbed at any user configured with the :haze action

https://travis-ci.org/

Some users like to fire multiple messages in rapid succession.

Currently steven will count each one of those messages individually towards the counter used to decide when to say something.

It would be better if steven received the first message and waited for a few seconds then incremented the counter. To make sure the user isn't firing many messages off.

Users should be created if they do not exist when passed into the addaction command. The adduser command should be removed.

Users should be able to be destroyed by the bot owner using the !removeuser command

It would be nice to have both a timed and untimed mute option, without kicking him off the server

currently, if adding action to user 'cool-ass username', Steven will assume that the username is just 'cool-ass'

Add ability to schedule responses of any type on a set schedule (daily, weekly, or monthly as opposed to "in five minutes from now")

Allow server administrators to use admin commands, as well as the owner, which is configured upon running Steven for the first time

I was able to get the bot running but I had install bundler and then run bundler install to install the dependencies.

Since some people working on this may not be as familiar with Ruby or installing dependencies, I think we should add information about installing dependencies to the README