The transitstacks from cal-itp

[BUG] transitstacks.io.example_dir() loops over non-existent dir

Describe the bug

When calling this method with a non-existent directory name, the code attempts to loop over that directory to build a list of available examples. It should instead loop over the root of the examples directory.

To Reproduce

See the Run output from the Python package GitHub Action

Failing tests

tests/test_basic.py:test_csv_io()

Triggering line of code

transitstacks/io.py:139:

def example_dir(example_name: str):
    """Takes an example name and returns the directory.

    Args:
        example_name: name of example
    """
    
    package_dir = os.path.dirname(os.path.abspath(__file__))
    main_example_dir = os.path.join(os.path.dirname(package_dir), "examples")

    example_dir = os.path.join(main_example_dir, example_name)
    
    if not os.path.exists(example_dir):
        available_examples = [
            name for name in os.listdir(example_dir) if os.path.isdir(name)  #<---- error here
        ]

Thoughts on resolution

def example_dir(example_name: str):
    """Takes an example name and returns the directory.

    Args:
        example_name: name of example
    """
    
    package_dir = os.path.dirname(os.path.abspath(__file__))
    main_example_dir = os.path.join(os.path.dirname(package_dir), "examples")

    example_dir = os.path.join(main_example_dir, example_name)
    
    if not os.path.exists(example_dir):
        available_examples = [
            name for name in os.listdir(main_example_dir) if os.path.isdir(name)  #<---- os.listdir(main_example_dir)
        ]

Full stack trace

[FEATURE] Add Transit Stacks to GCS

User Story

As @mcplanner, I'd like to know which vendors are associated with GTFS errors
As @hunterowens, I'd like our data stack to center around our GCS cloud infrastructure and not directly rely on querying Google Sheets

Priority

Medium

Tests

All.

[BUG] /icons not found when running tests on GitHub Actions

Describe the bug

The icons in /icons are not found when running tests on GitHub Actions which means they aren't getting installed.

To Reproduce

Steps to reproduce the behavior:

Run Github Action test.yml

Thoughts on resolution

Perhaps something is not working with MANIFEST or package data?

cal-itp / transitstacks Goto Github PK

transitstacks's People

Contributors

Watchers

transitstacks's Issues

Describe the bug

To Reproduce

Failing tests

Triggering line of code

Thoughts on resolution

Full stack trace

User Story

Priority

Tests

Describe the bug

To Reproduce

Thoughts on resolution

Recommend Projects

Recommend Topics

Recommend Org