Coder Social home page Coder Social logo

Incorrect shadows about sodium-fabric HOT 6 CLOSED

caffeinemc avatar caffeinemc commented on May 18, 2024
Incorrect shadows

from sodium-fabric.

Comments (6)

StealWonders avatar StealWonders commented on May 18, 2024 1

Issue is non-existent on the latest commit as of now. I'ma close this!

from sodium-fabric.

jellysquid3 avatar jellysquid3 commented on May 18, 2024

Sodium re-implements the entire smooth lighting engine in order to improve chunk rendering performance and to fix a few graphical issues. As a result, the rendering between the two will not always be identical.

However, it is rather difficult for me to tell the difference between these screenshots as they've been compressed heavily and the camera moves between each shot. If you're able to, cleaner images would help a lot in diagnosing this problem.

from sodium-fabric.

lenrik1589 avatar lenrik1589 commented on May 18, 2024

It might not be obvious as the marking is not clear but if you look near big outline just on the inner side some blocks look de-saturated/brightened
in this area:
sodium#22_area_selected
Alot more contrast:
sodium#22_contrast_a_bit_more_sane
Edge here:
sodium#22_contrast_a_bit_more_sane_edge
this should make it a bit clearer

from sodium-fabric.

StealWonders avatar StealWonders commented on May 18, 2024

Sorry for the images but the issue is hardly noticeable.

No sodium:
2020-06-21_19 21 50

With sodium:
You may be able to tell that the wall of the house is outlined by a two block wide lighter grass strip.
2020-06-21_19 21 03

Image highlighting the border of where the shadows are to make it more clear.
ApplicationFrameHost_H7wkqAit9E

Light level near the house (using Vanilla):
javaw_XYtrrbdXjh

Light level further away from the house (using Vanilla):
javaw_mYKfgFa0hL

The light levels are the same when using sodium of course but the coloring of the grass (shadows) is brighter than normal grass which makes no sense...

from sodium-fabric.

jellysquid3 avatar jellysquid3 commented on May 18, 2024

Are you using the latest revision of Sodium? There were some issues in an earlier version with the vertex encoding stage that caused weirdness like this.

from sodium-fabric.

StealWonders avatar StealWonders commented on May 18, 2024

Are you using the latest revision of Sodium? There were some issues in an earlier version with the vertex encoding stage that caused weirdness like this.

Let me recompile. Here are some further screenshots of the issue for now:

javaw_I1QwmFSH4n

javaw_qXMnOiGbu8

from sodium-fabric.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.