cabbage-ex / gherkin Goto Github PK

Hello,

I have a table with cell values that contain pipe characters, such as the first cell on the second row in this table:

| MatterTypeFullPath                        | ApprovedTax | ApprovedTotalExcludingTax | LockedExchangeRate |
| Litigation/Dispute\|Potential Dispute     | 12.0        |  133.09                                  | 1.0                               |

Escaping the pipe character works fine in most Gherkin engines AFAIK. But here it doesn't.
Is there a workaround?

Thanks!

Is it possible to publish the new version on hex.pm ?

Fix these:

==> gherkin
Compiling 8 files (.ex)
warning: String.rstrip/1 is deprecated, use String.trim_trailing/1
  lib/gherkin/parser/helpers/feature.ex:22

warning: String.strip/1 is deprecated, use String.trim/1
  lib/gherkin/parser/helpers/feature.ex:26

warning: String.strip/1 is deprecated, use String.trim/1
  lib/gherkin/parser/helpers/tables.ex:49

warning: String.lstrip/1 is deprecated, use String.trim_leading/1
  lib/gherkin/parser.ex:31

warning: String.lstrip/1 is deprecated, use String.trim_leading/1
  lib/gherkin/parser.ex:37

warning: String.lstrip/1 is deprecated, use String.trim_leading/1
  lib/gherkin/parser.ex:45

warning: String.strip/1 is deprecated, use String.trim/1
  lib/gherkin/parser/generic_line.ex:102

Generated gherkin app

I just started using cabbage with my phoenix app, and it's great ! If I translate my features into another language than english (eg. adding #language: fr at the top of my features) the test steps are just ignored. Have I missed something or is this feature not supported by this gherkin parser ?

It looks like a new version of this library was released on hex a little over 1 month ago. Glad to see it gaining a new maintainer.

Unfortunately this new release is causing an issue. #8 was a breaking change and the version was set to 2.0.0 appropriately. But it looks like the version was later changed to 1.6.1 in 3d013c8 and then released to hex.

I'm not sure what would be the best approach here. Would it be possible to yank v1.6.1 from hex and re-release it as 2.0.0 instead?

In the mean time the work around for us was to pin 1.6.0 in our mix.exs file.

Whitebread has some filters that make use of a 'role' for a feature.

This was removed here: e838907#diff-d25be551329fc7c7234e014e4d849b9fL157

Any opposition to adding it back?

This implementation fails to parse some of the testdata of the official monorepo.
For instance, when I try to parse complex_background.feature, I get:

** (RuntimeError) Unexpected line: Examples:
    (gherkin 2.0.0) lib/gherkin/parsers/rule_parser.ex:43: Gherkin.Parsers.RuleParser.build_rule/2
    (gherkin 2.0.0) lib/gherkin/parsers/feature_parser.ex:51: Gherkin.Parsers.FeatureParser.build_feature/2
    (elixir 1.10.1) lib/enum.ex:1396: Enum."-map/2-lists^map/1-0-"/2

Feature: Something

  @first_tag
  @second_tag
  Scenario: A scenario
    Given Something

This should result in the tags being ["first_tag", "second_tag"], yet it only contains ["second_tag"]