c9 / connect-architect

build a connect server using architect plugins

connect-architect

Connect for architect.

Demo

npm install
cd ./demo
node server
open http://localhost:8080

Test

npm install
npm test

connect-architect's Issues

TypeError: Object # has no method 'modified'

Throws up this error ... . When i type http://localhost:8080/ I dont think the method Utils.modified exists in the connect 2.7.6 specified in the package.json.

/code/github.com/connect-architect/connect/middleware/static.js:184
if (!utils.modified(req, res)) {
^
TypeError: Object # has no method 'modified'
at /code/github.com/connect-architect/connect/middleware/static.js:184:18
at Object.oncomplete (fs.js:107:15)

Enable travis-ci hook & put on ci.c9.io

Ensure gzip files still work with static middleware (c9local)

Arbitrary port should be propagated to other plugins?

Given a listen port of value 0, the OS will select a random, available port automatically. In an architect system, the real port can be retrieved as follow:

    architect.createApp(
        architect.resolveConfig(
            plugins,
            path.join(dirname, 'plugins-server')),
        function (err, app) {
           if (err) {
               console.error("While starting the '%s' for '%s':", dirname, workdir);
               cb(err);
           } else {
               console.log("Started '%s' for '%s'!", dirname, workdir);
               var address = app.services.http.getServer().address();
               cb(null, address);
           }
        }
    );

However, due to the plugin nature of Architect, this system selected port is not propagated to other modules that depend on that port.

In Cloud9 for example we have these configuration directives that directly take the port:

            packagePath: "./cloud9.core",
            debug: false,
            fsUrl: fsUrl,
            smithIo: {
                port: port,
                prefix: "/smith.io/server"
            },

or:

        }, {
            packagePath: "vfs-architect/http-adapter",
            mount: vfsUrl,
            httpRoot: "http://localhost:" + port + vfsUrl
        }, {
            packagePath: "./cloud9.fs",
            urlPrefix: fsUrl
        },
        "./cloud9.socket",
        {
            packagePath: "connect-architect/connect.session",
            key: "cloud9.sid." + port,
            secret: "v1234"
        },

...although my Cloud9 instance "seems" to be working (without any error on the console) with this arbitrary port, I'm wondering about the impact of passing a port 0 to all these different plugins...

Error 'SyntaxError: Unexpected end of input' reading session

See: https://github.com/ajaxorg/cloud9/issues/1614

This bug existed before the session plugin was moved over to this repo but the fix for it was not ported during that move (the fix is linked to in the above issue). I've hit the same bug again now.