c42f / displaz.jl Goto Github PK

Apart from supporting the color field - passing normals through to displaz for shading seems like something that could be useful. At the same time it would then be relevant to also allow the shader to be selected (without having to manually change it in).

@c42f please let me know what you think - I'll post a PR soon

When I try to run the simple example in the README:

using Displaz

plot3d!(10*randn(3,100000))

ERROR: could not spawn displaz -script -server default -label 'Points [100000 vertices]' -shader generic_points.glsl -rmtemp /tmp/juliaH7jSmY.ply: no such file or directory (ENOENT)
in _jl_spawn(::String, ::Array{String,1}, ::Ptr{Void}, ::Base.Process, ::RawFD, ::RawFD, ::RawFD) at ./process.jl:321
in #412 at ./process.jl:478 [inlined]
in setup_stdio(::Base.##412#413{Cmd,Ptr{Void},Base.Process}, ::Tuple{RawFD,RawFD,RawFD}) at ./process.jl:466
in #spawn#411(::Nullable{Base.ProcessChain}, ::Function, ::Cmd, ::Tuple{RawFD,RawFD,RawFD}, ::Bool, ::Bool) at ./process.jl:477
in run(::Cmd) at ./process.jl:591
in #plot3d#9(::Array{Int64,1}, ::Array{Float64,1}, ::Array{Int64,1}, ::Void, ::Array{Int64,1}, ::Bool, ::Array{Any,1}, ::Function, ::Displaz.DisplazWindow, ::Array{Float64,2}) at /home/juliohm/.julia/v0.5/Displaz/src/Displaz.jl:327
in (::Displaz.#kw##plot3d)(::Array{Any,1}, ::Displaz.#plot3d, ::Displaz.DisplazWindow, ::Array{Float64,2}) at ./:0
in #plot3d!#13(::Array{Any,1}, ::Function, ::Displaz.DisplazWindow, ::Array{Float64,2}) at /home/juliohm/.julia/v0.5/Displaz/src/Displaz.jl:341
in plot3d!(::Displaz.DisplazWindow, ::Array{Float64,2}) at /home/juliohm/.julia/v0.5/Displaz/src/Displaz.jl:341
in #plot3d!#14(::Array{Any,1}, ::Function, ::Array{Float64,2}) at /home/juliohm/.julia/v0.5/Displaz/src/Displaz.jl:346
in plot3d!(::Array{Float64,2}) at /home/juliohm/.julia/v0.5/Displaz/src/Displaz.jl:346

Julia plotting in general is standardizing on ColorTypes.jl and Colors.jl for color handling. At a minimum, plot3d() should be able to handle colors from ColorTypes.

This will make automated build testing easier for anyone interested in putting Displaz into their REQUIRE file

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

I am not sure why this is happening, but I get no colors shown if I do:

using Displaz

fig = Displaz.newfigure()
clearplot(fig)
plot3d!(fig, rand(3,10), color=[Colors.RGB(1.0,1.0,0.0) for i=1:10])

In contrast to it working if I do

using Displaz

fig = Displaz.newfigure()
plot3d!(fig, rand(3,10), color=[Colors.RGB(1.0,1.0,0.0) for i=1:10])

This may have to do with the shader set by plot3d!, but from what I see it is hardcoded to generic_points.glsl, could it be that it's being overriden by Displaz itself (the binary)?

Just a personal opinion - but would it make more sense to call the function displaz() instead of plot3d(), like the command line displaz? There seems to be export clashes with other common plotting packages. (What might make more sense is to add a Displaz backend to Plots.jl, if we want to think of displaz as a plotter)

In debugging my code I tend to append a debug flag to functions that I would like to plot data in. It would be nice to set globally whether plots can be silenced/muted. Is this a feature that would be useful or would it be adding more overhead?

Current typical usage:

function main(debug_flag::Bool = false)
    dostuff(debug_flag)
end

function dostuff(debug_flag)
     debug_flag && plot3d!(rand(3,10000))
end

Proposed usage:

function main(debug_flag::Bool = false)
    debug_flag == false && disable_plot()  # Have this at the start of top level function
    dostuff()
end

function dostuff()
     plot3d!(rand(3,10000))    # This won't do anything
end

Hi, I'm having trouble getting this installed on OS X.
I updated docutils and cmake, cloned the displaz repo, and ran the OS X instructions in the .travis.yml file. Everything seemed to go smoothly. I then installed the Displaz.jl package.

I had to export PATH=/Users/michael/Documents/github/displaz/build/bin:$PATH in order for julia to find displaz. Now I get the displaz window opening with plot3d!(10*randn(3,100000)), but lots of error messages:

OpenGL implementation:
  GL_VENDOR    = Intel Inc.
  GL_RENDERER  = Intel(R) Iris(TM) Graphics 6100
  GL_VERSION   = 4.1 INTEL-10.25.17
  GLSL_VERSION = 4.10
  GLEW_VERSION = 2.0.0
ERROR: Could not read cursor shader.
ERROR: Could not read axes shaders
ERROR: Could not read grid shader.
ERROR: Couldn't open shader file "shaders:las_points.glsl": No such file or directory
ERROR: Couldn't open shader file "generic_points.glsl": No such file or directory
/var/folders/b8/rvm2dk495f74088ssh9v2l8r0000gn/T/julia88Butv.ply: float[3] position
/var/folders/b8/rvm2dk495f74088ssh9v2l8r0000gn/T/julia88Butv.ply: float[3] color
/var/folders/b8/rvm2dk495f74088ssh9v2l8r0000gn/T/julia88Butv.ply: float[1] markersize
/var/folders/b8/rvm2dk495f74088ssh9v2l8r0000gn/T/julia88Butv.ply: int32_t[1] markershape
Loaded 100000 of 100000 points from file /var/folders/b8/rvm2dk495f74088ssh9v2l8r0000gn/T/julia88Butv.ply in 0.13 seconds

Do I need to add more things to PATH?

Also, the installation instructions say I need LASlib to open .las files, but the link does not provide any installation instructions. You may not be able to help with this, just checking that I should be able to work this on my Mac? (it seems very windows-specific).

Thanks!