c0xc / nomacs Goto Github PK

Describe the bug
Nomacs v3.17 seems to have a broken crop feature. First of all, clicking on "crop" shows a white grid on top of the image, which is quite distracting. I don't know how to crop a section of the image which doesn't fit on the screen all at once. The selected area moves around when zooming, it doesn't stick to the image...

Expected behavior
Like in <= v3.16.

Additional context
As I don't see the value of this white grid thing now, I'm tempted to revert all relevant changes since v3.16 (or even fork v3.16). OTOH, I'm hesitant, maybe someone prefers this new thing, in which case it should be evaluated how much overhead it might be to keep this new crop-like feature as another tool. Either way, the original crop feature needs to be restored.

With the meta data info panel enabled, keyboard navigation is not working because the filter field above it consumes all keyboard events. I have this panel enabled because I want to see the exif data and also, I want to know where the nsa thinks I was (how about an nsa button...).

This means that, when browsing through a collection of images, opening some, you first have to grab the mouse and click into the window or hit tab twice. Only then, you can use the arrow keys to navigate within Nomacs.

There should be a feature to retain the file date (mtime) after minor modifications. I consider rotating and, in some cases, cropping to be minor changes or corrections (when a photo is initially sideways, rotating is just a correction, no editing).

Upstream feature request:
nomacs#804

Some notes on that topic:
nomacs#804

Describe the bug
Original upstream bug report:
nomacs#799

To Reproduce
Steps to reproduce the behavior:

1. Use default settings
2. Open JPEG image
3. Rotate it and navigate away
4. User isn't notified about change, file is updated later

Expected behavior
In most cases, rotating an image should be like any other modification (say, resizing or blurring parts of the image), it should somehow mark the image as edited and, when navigating away, ask the user to save the changes.

More importantly, there shouldn't be anything that saves or updates a file in the background without getting the user's consent.

Additional context
This also affects the history, i.e., it's not possible to undo a rotation.