Coder Social home page Coder Social logo

refactor_first's Introduction

Grupo 2

Integrantes

  • Cristobal Martinez
  • Carlos Aguirre

CodeSmell por Reek

Usando el comando rekk encontramos los siguientes code smells

  reek

1.- Codigo Duplicado 2.- DuplicateMethod Call 3.- FeatureEnvy 4.- Too many Statements

CodeSmell Encontrados

  • Feature Envy

    • La clase Rental debiera ser la encargadda de calcular el costo de la pelicula y no la persona. Esto es un problema (Single Responsability de SOLID) ya que no podemos reutilizar el codigo y ademas genera mucha responsabilidad para la clase.
  • Comments

    • Comentarios Innecesarios
      • Ej:
          # add frequent renter points
          frequent_renter_points += 1
        
  • Long Method

    • El metodo statement de la clase customer tiene mucha responsabilidades y es demasiado largo. Apenas cabe en una pagina.
    • Es malo porque es un indicio que tiene muchas responsabilidades
    • Funcionalidades debieran ser de la clase rental como por ejemplo:
      • Calcular precio
      • Calcular Bono

refactor_first's People

Contributors

c-aguirre017 avatar pitosalas avatar

Watchers

 avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.