Coder Social home page Coder Social logo

byu-theme-components's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

byu-theme-components's Issues

Search Alignment

The "S" in search needs to be left aligned with the "B" in BYU regardless of mobile width.

image

Department Name font

Mobile view should have a wrapped title with smaller font instead of ellipses (see instructions)

image

image

Margin if no search bar

The margin on the right needs to always match the margin on the left. Please add padding between end of "sign out" and end of page.

image

Social Media Icons

We'll need to adjust the social media icons in the footer. (see pinned image on engineering board for instructions)

image

Documentation need to switch <h1> to <span> for title

One-Line Summary

tag needs to be replaced with tag for the site title

Websites Affected

If this is a bug or styling issue, please list one or more URLs where
we can see the issue.

http://2017-components-demo.cdn.byu.edu/index.html

Issue Type

Typo
Is this (add an x in the boxes that apply)

  • A difference between the components and the Official Specification?
  • A bug, such as a Javascript error, or the UI not rendering properly
    on a page?
  • Inconsistent appearance/behavior between browsers?
  • An issue on mobile browsers?
  • A request for a new feature/enhancement?

Browsers Affected

Add an x in all the boxes that apply. Please mark desktop and mobile
browsers separately.

We support the last two versions of Chrome, Firefox, Safari, and Edge,
plus Internet Explorer 11.

Desktop Browsers

  • Google Chrome
  • Mozilla Firefox
  • Apple Safari
  • Microsoft Edge
  • Microsoft Internet Explorer 11
  • Other (please specify)

Mobile Browsers

  • Any browser on iOS
  • Chrome for Android
  • Firefox Mobile for Android
  • Other (please specify)

Web Site Platform

What is hosting your website?

  • Drupal 7
  • Drupal 8
  • Wordpress
  • Custom Site
  • Don't Know

Detailed Description

Tell us all about your problem or feature proposal.
Change the documentation on the page above to have a span tag rather than an h1 tag. The h1 causes the title to be way too big.
If the issue is with styling, please include screenshots!

Title Spacing

As page width shrinks, space between "BYU" and start of Department name should still remain the same as full width.

image

Header alignment

I believe this is already being addressed by @kebowdog, but please just ensure that anytime there are two lines, it is aligned top and bottom with the BYU logo. In the attached instance, you can simply adjust the line height to make that happen. Let me know if you have any questions on other instances.

image

Phone Number

Please change the phone number in the footer to have dashes, and call when it is clicked

image

Footer alignment

If only three columns, when this starts to wrap the third column should be left aligned, not centered.

image

Footer font

Somewhere along the way we lost the Gotham font on the copyright line. Can we please include it again?

img_0078

Blue underline appearing under mobile search

Can we eliminate the blue underline appearing under the mobile search bar? I've attached two examples (one with, one without). Perhaps it is only occurring in the drupal theme? Do we have any other websites we can check?

img_1150
img_1151

Make byu-header handle h1-6 tags in the site-title slot

One-Line Summary

Currently, header tags don't get styled properly when used as a site-title. See #153

Websites Affected

If this is a bug or styling issue, please list one or more URLs where
we can see the issue.

All

Issue Type

Is this (add an x in the boxes that apply)

  • A difference between the components and the Official Specification?
  • A bug, such as a Javascript error, or the UI not rendering properly
    on a page?
  • Inconsistent appearance/behavior between browsers?
  • An issue on mobile browsers?
  • A request for a new feature/enhancement?

Browsers Affected

All

Web Site Platform

All

Detailed Description

Tell us all about your problem or feature proposal.

Nav Bar Icons

If there are less than 5 items in the nav bar, keep them left instead of centered on the page.

image

Font weight

Please change font weight to 500 instead of 400 on gotham everywhere except the copyright line in the picture below

image

iPad view

Is this an accurate view of where the code is at for iPads?
Seems the search bar needs some love

img_0077

Footer line height

Try 7px line-height between Brigham Young University and copyright line.
Also, lets increase the width of BYU logo to 450 px so it is wider than copyright line

image

image

Active State

Looks like somewhere along the way the "active state" stopped working with components. Could we get that adjusted so that the page I'm on displays grey in the nav bar again?

image

Opening Menu causes footer to shake

Please watch the footer "Brigham Young University Logo" as you open and close the mobile menu. It seems it can't decide on what size it wants to be and shakes in and out instead. Let me know if you want me to clarify.

image

search

I'm aware this isn't working quite yet, but once it is - can we just make sure that the functionality to hit enter to search works the same as clicking the icon to search?

Also this needs to be big enough that the "search" text can be the same size as text in the nav bar beneath it - - in gotham 500.

image

Content Security Policy - blocked "unsafe eval" and "unsafe inline"

One-Line Summary

CSP blocks the use of unsafe inline scripts and the use of eval or similar functions in javascript.

Websites Affected

We haven't pushed the theme to an externally visible location yet but if necessary we can probably get you something to look at.

Issue Type

  • A difference between the components and the Official Specification?
  • A bug, such as a Javascript error, or the UI not rendering properly
    on a page?
  • Inconsistent appearance/behavior between browsers?
  • An issue on mobile browsers?
  • A request for a new feature/enhancement?

Browsers Affected

Desktop Browsers

Haven't tested with any other browsers but may be present.

  • Google Chrome
  • Mozilla Firefox
  • Apple Safari
  • Microsoft Edge
  • Microsoft Internet Explorer 11
  • Other (please specify)

Mobile Browsers

  • Any browser on iOS
  • Chrome for Android
  • Firefox Mobile for Android
  • Other (please specify)

Web Site Platform

  • Drupal 7
  • Drupal 8
  • Wordpress
  • Custom Site
  • Don't Know

Detailed Description

Content Security Policy will block parts of the scripts used by the BYU theme components, resulting in obvious issues in styling and rendering of some content period.

The error as reported in the JS console on google chrome:

image

How it renders the page:

chrome_render_example

Firefox:

image

Render on Firefox:
screenshot from 2017-04-14 12-45-48

To reproduce, adding the header "Content-Security-Policy: script-src 'self' *; style-src 'self' 'unsafe-inline' *;" seems sufficient.

The original site (for reference; byu-theme is not yet applied in production) can be found here.

Give Button

Font weight for Vitesse should be 400, not 500. Also, please center vertically.

image

Header with two lines

Second line should be 12pt font instead of 14pt, per instruction sheet. This should help create a little more line height so they aren't going to run into each other.

image

Margins

Amount of blue space before "BYU" on left is perfect. Please add padding on the right side of menu icon to match.

image

Search Box + proportions

Please make sure grey button in search box is larger than menu icon above it. Menu icon and search icon should be the same size.

image

image

Max Width

Please set the max width of the header and footer at 1200px. This should be the default, with the option to be be full width if they choose.

Footer Text

Please center vertically. It is currently closer to the bottom than the top.

image

mobile search width

The search bar width in mobile is inconsistent. Some times with width is greater than 100% and sometimes it is less than 100%

Area Footer Vitesse Weight

Font weight for Vitesse headers everywhere should be 400, not 500

Please make to look like this:
image

Currently looks like this:
image

Centered links on navigation bar

Links on nav bar should be centered, unless there are 3 or less. Then please left align with the beginning of the College/Department (see green line below)

image

image

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.