bwalter / aidl-lsp Goto Github PK

The LSP server gives an "Unrecognised token" error for the following AIDL file, which the AIDL compiler accepts:

package test;

union TestUnion {
    String a;
    String b;
}

https://github.com/bwalter/aidl-lsp/blob/main/editors/code/package.json and https://github.com/bwalter/aidl-lsp/blob/main/editors/code/LICENSE says that everything is under the MIT license and copyright Benoit Walter, but the TextMate grammar https://github.com/bwalter/aidl-lsp/blob/main/editors/code/aidl.tmLanguage.json has been copied from https://github.com/google/aidl-language which is copyright Google LLC and released under the Apache License version 2.0.

Please correct the copyright notices and license information in this project to make that clear.

The LSP server gives an error "Missing direction for Test" for this interface:

package test;

import test.Test;

interface TestInterface {
    void test(Test test);
}

However, the AIDL compiler allows it.

When parsing an AIDL file which refers to a ParcelFileDescriptor, the LSP server gives an error that it is an unknown type. However ParcelFileDescriptor is a builtin type, so it can be used without any import.

e.g.

package test;

parcelable Test {
    ParcelFileDescriptor file;
}

AIDL allows enums to be nested under parcelables, but the LSP server doesn't accept it. E.g.:

package test;

parcelable TestWithEnum {
    enum TestEnum {
        ONE,
        TWO,
    }

    TestEnum number;
}