busterc / promise-do-whilst Goto Github PK

hey,

thanks for this promise helper. I just realized while using, it would be more comfortable if the result of the action function could be passed to the condition function. see #2

Hello!

Thank you for this great module!

However, I have some unexpected behavior with thrown errors: when I throw an error from inside of action function, it's silenced somehow when the rejection is not caught.

Here's the simplified example:

const Promise = require('bluebird');
const promiseDoWhilst = require('promise-do-whilst');


foo().then(result => console.log('Result', result));
// Error is displayed in the console.

bar().then(result => console.log('Result', result));
// Error is ignored, no output.


function foo () {
  return Promise.resolve().then(() => {
    throw new Error('Some error');
  });
}

function bar () {
  return promiseDoWhilst(() => {
    throw new Error('Some error');
  }, () => true);
}

I do prefer to see all thrown errors in the output of the Node.js application.

Thanks!