buntec / ff4s Goto Github PK

I was wondering why the store function looks like:

Action => State => (State, Option[F[Unit]])

vs

Action => State => (State, F[Unit])

Since we know that F[_]: Concurrent and Concurrent extends Applicative so we could return F[Unit] via Concurrent[F].unit instead of None.

There is possibly an efficiency motivation, but if there isn't, I think the simpler type signature would be cleaner to use.

This looks like a great library that I'm excited to try. One of the reasons I love typed functional programming is that the type signatures are often great documentation.

Would you be willing to publish the scala docs for this library so that we can easily see the types without having to click through the GitHub UI or checking the project out locally?

Thanks for your work on this!

I'm enjoying using ff4s on a simple UI. I really enjoy programming with cats and pure functional style, so I appreciate your work on this.

I've shown this library to a few people and one place they always trip up is explaining with Store is named what it is. The main thing it seems to be about is the updating logic of (Action, State) => State. Or someone with more FP experience might notice that it something like Action => cats.data.State[State, Option[IO[Unit]]

I don't have a great suggestion for you, but I noticed you are still making incompatible changes, so I thought I would bring the issue up. Something more direct like Update, or maybe TransitionMatrix.

Just thought I would share my feedback.

I have some code that looks like this:

        textArea(
          `type` := "text",
          cls := "codein",
          value := text,
          onInput := { te =>
            Some(
              Action.CodeEntered(
                te.currentTarget.asInstanceOf[HTMLTextAreaElement].value
              )
            )
          }
        )

It would be nice if the type of the event allowed me to access the HTMLTextAreaElement without the cast. Maybe it is possible now, but I didn't see how.

Thank you.