Coder Social home page Coder Social logo

assign-reviewer-by-label's People

Contributors

buildsville avatar dependabot[bot] avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

assign-reviewer-by-label's Issues

Approving the PR doesn't always reflect the approval in the "Reviewers" area

We're using this GitHub Action to assign reviewers to PRs based on the teams they're in. We've got labels for:

  • Frontend
  • Backend
  • DevOps

Several of the team members are in multiple teams, and the person raising the PR will almost always be part of the team(s) they are labelling the PR for.

Our YAML file looks like this:

name: Assign Reviewers by Label
on:
  pull_request:
    types:
      - opened
      - unlabeled
      - labeled

jobs:
  assign_frontend:
    runs-on: ubuntu-latest
    name: Assign Frontend Team
    steps:
      - name: Assign Frontend Team
        id: reviewer
        uses: buildsville/assign-reviewer-by-label@v1
        with:
          token: "${{secrets.GITHUB_TOKEN}}"
          labels: '[ "Frontend" ]'
          reviewers: '[ "person1", "person2", "person3"  ]'
  
  assign_backend:
    runs-on: ubuntu-latest
    name: Assign Backend Team
    steps:
      - name: Assign Backend Team
        id: reviewer
        uses: buildsville/assign-reviewer-by-label@v1
        with:
          token: "${{secrets.GITHUB_TOKEN}}"
          labels: '[ "Backend" ]'
          reviewers: '[ "person2", "person4", "person5" ]'
  
  assign_devops:
    runs-on: ubuntu-latest
    name: Assign DevOps Team
    steps:
      - name: Assign DevOps Team
        id: reviewer
        uses: buildsville/assign-reviewer-by-label@v1
        with:
          token: "${{secrets.GITHUB_TOKEN}}"
          labels: '[ "DevOps" ]'
          reviewers: '[ "person1", "person6" ]'

The reviewers are added to the PR as expected. However, we've noticed that occasionally, a review has to approve the PR multiple times before the reviewer is shown to have approved the PR in the reviewers' area of the sidebar. GitHub will show in the timeline that the user did approve the PR.

This only started happening after we started to use this GitHub Action. It may well be a GitHub bug, rather than an issue with the action itself, but I was wondering if you'd be able to advise. Thank you.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.