Comments (8)
On a second thought, I have a different proposal.
Changes to recommended rules are clearly marked as breaking in eslint releases.
How about we fix to a specific version of eslint (e.g. 2.4) and when we manually update it, we check for breaking changes (as we should do anyway)?
from eslint-config.
Is this still actual?
from eslint-config.
I actually think we should do the opposite: we're relying on eslint:recommend
for rules we find useful. Unfortunately they're not simply adding rules to the recommended group, sometimes they're removing some from it or editing them (ex: eslint/eslint@79ebbc9)
I think it would be safer and more stable to repeat the rules we're 100% sure we want wether or not they're recommended (we can still keep eslint:recommended
as an integration)
from eslint-config.
I agree. If the set of rules is not stable and not under our control, let's just copy them over and be done with it.
from eslint-config.
always in favor of pinning versions 👍
from eslint-config.
I took a look at this, and it looks like eslint is not introducing breaking changes on minor releases, so I think our peer dependency on ^2.4.0
is already good enough.
Thoughts @buildo/frontend?
from eslint-config.
How about we fix to a specific version of
eslint
(e.g. 2.4) and when we manually update it, we check for breaking changes (as we should do anyway)?
I agree... but let's remember to check! :)
from eslint-config.
Ok. Nothing do do here. :)
from eslint-config.
Related Issues (20)
- curly HOT 6
- rule proposal: method names HOT 2
- max-len should ignore URLs, strings and imports HOT 4
- update eslint peer dep
- rule proposal: promise plugin HOT 8
- Empty lines HOT 15
- upgrade eslint-plugin-react HOT 1
- upgrade eslint-plugin-no-loops
- Create test project to test our rules against
- Find a way to document code HOT 1
- Evaluate eslint-plugin-compat HOT 6
- Add array-bracket-spacing
- Add spaced-comment and no-multi-spaces HOT 4
- Add gdsm to linto config
- Add consistent-return HOT 4
- add eslint-plugin-import/first
- pin eslint-plugin-react to <6.10.1 HOT 2
- Disallow Use of `undefined` Variable (no-undefined) HOT 2
- Enfore space before '/>' in self-closing tags HOT 14
- add smooth release
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eslint-config.