why are we repeating some rules from eslint:recommended? about eslint-config

[gabro]

On a second thought, I have a different proposal.

Changes to recommended rules are clearly marked as breaking in eslint releases.

How about we fix to a specific version of eslint (e.g. 2.4) and when we manually update it, we check for breaking changes (as we should do anyway)?

[gabro]

Is this still actual?

[FrancescoCioria]

I actually think we should do the opposite: we're relying on eslint:recommend for rules we find useful. Unfortunately they're not simply adding rules to the recommended group, sometimes they're removing some from it or editing them (ex: eslint/eslint@79ebbc9)
I think it would be safer and more stable to repeat the rules we're 100% sure we want wether or not they're recommended (we can still keep eslint:recommended as an integration)

[gabro]

I agree. If the set of rules is not stable and not under our control, let's just copy them over and be done with it.

[giogonzo]

always in favor of pinning versions 👍

[gabro]

I took a look at this, and it looks like eslint is not introducing breaking changes on minor releases, so I think our peer dependency on ^2.4.0 is already good enough.

Thoughts @buildo/frontend?

[FrancescoCioria]

How about we fix to a specific version of eslint (e.g. 2.4) and when we manually update it, we check for breaking changes (as we should do anyway)?

I agree... but let's remember to check! :)

[gabro]

Ok. Nothing do do here. :)