Comments (8)
Do we agree in adding this with default settings?
from eslint-config.
Interesting! I don't have (yet?) an opinion about each rule/case, but in general I have the feeling that some of them would be useful immediately.
If more people find this promising I think we should test each rule and report here the current amount of "errors" we have in QIA/AlinIQ
from eslint-config.
👍 ok for me, wanna list the ones you would include?
from eslint-config.
As most of the time those rules are already shared, but not enforced, so my personal list would be
Simple and efficient
"promise/always-return": 2
Never saw in our code, anyway enforce it could be helpful
"promise/no-return-wrap": 2,
Not really useful (should we check param names for all lambdas we have)?
"promise/param-names": 0,
I ofter personally omit the catch
part of a promise cause I'm confident errors will never happen 🙈
"promise/catch-or-return": 2
"In an ES5 environment, ..." we (buildo) are never in an "ES5 environment" nowadays
"promise/no-native": 0,
from eslint-config.
Not really useful (should we check param names for all lambdas we have)?
no but this one is a very special one ( a "revealing constructor" one https://blog.domenic.me/the-revealing-constructor-pattern/ , lol btw :P )
so I'm in favor of keeping the resolve
and reject
names consistent
from eslint-config.
What @ascariandrea proposes is all 👍 for me, with the exception of param-names
for which I agree with @giogonzo
from eslint-config.
(keeping param-names
I think we end up in the default setting for this rule)
from eslint-config.
Full force ahead! ✌️ But please make sure to fix projects before merging
from eslint-config.
Related Issues (20)
- curly HOT 6
- rule proposal: method names HOT 2
- max-len should ignore URLs, strings and imports HOT 4
- update eslint peer dep
- Empty lines HOT 15
- upgrade eslint-plugin-react HOT 1
- upgrade eslint-plugin-no-loops
- Create test project to test our rules against
- Find a way to document code HOT 1
- Evaluate eslint-plugin-compat HOT 6
- Add array-bracket-spacing
- Add spaced-comment and no-multi-spaces HOT 4
- Add gdsm to linto config
- Add consistent-return HOT 4
- add eslint-plugin-import/first
- pin eslint-plugin-react to <6.10.1 HOT 2
- Disallow Use of `undefined` Variable (no-undefined) HOT 2
- Enfore space before '/>' in self-closing tags HOT 14
- add smooth release
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eslint-config.