Comments (5)
Agreed, checking for any custom/USERDEFINED predefined type feels useful. This shouldn't preclude implicitly checking the ObjectType.
- Standard case: All Doors defined as TrapDoor (PredefinedType = TRAPDOOR)
Entity Facet:
- IfcType: IFCDOOR
- PredefinedType: TRAPDOOR
- User defined scenario All Doors defined as 'SecurityDoor' (ObjectType = 'SecurityDoor' [and PredefinedType = USERDEFINED])
Entity Facet:
- IfcType: IFCDOOR
- PredefinedType: SecurityDoor
- Edge case All Doors with any User-defined type (PredefinedType = USERDEFINED)
Entity Facet:
- IfcType: IFCDOOR
- PredefinedType: USERDEFINED
In particular, a use case might be: "All elements must NOT have a PredefinedType of USERDEFINED". That kind of test might help with #116, as presumably you could select applicable items with IfcFlowTerminal of Predefined Type 'DIFFUSER,GRILL' etc if you can exclude USERDEFINED and NOTDEFINED . This assumes implementations fall back to the Type to check the PDT - i.e [IfcAirTerminal]Type's PDT to filter the Ifc2x3 FlowTerminals.
It would also let IDS police the (mis)usage we sometimes see of IfcObject.ObjectType being defined when PredefinedType is NOTDEFINED - by combining an Entity requirement and an Attribute requirement.
from ids.
Hi @MatthiasWeise,
Constraining the PredefinedType is something I originally added, but have since relaxed.
Indeed the code infrastructure to enforce the closed list is still in the tool, but the agreement in the group is that we must allow for the selection of user defined values.
What I can easily do is to add a warning to the log, that notifies of non-standard strings, if that helps.
Would that be useful?
from ids.
Yes, a warning would be good to avoid misspelling of predefinedType.
Actually, I wanted to check if USERDEFINED is allowed or not. I would argue that we should allow USERDEFINED, and then to check that predefinedType = USERDEFINED and objectType can have any value.
from ids.
However that would prevent us from selecting specific parts of the models that have a custom predefinedType, which does not sound right.
We do need a test case that deals with some predefined type configuration, if we don't have one yet. I'll have to check.
from ids.
I was more thinking that we need both, USERDEFINED to be unspecific about what user defined type should be selected and to use any other value not being in the list of predefinedTypeEnums for a specific used defined type.
from ids.
Related Issues (20)
- Format of values in IDS HOT 1
- Default branch settings HOT 1
- Data type of IfcLengthMeasure "Real" or "Double"? HOT 1
- List of datatypes with Enum types used by attributes HOT 6
- List of datatypes without IfcCompoundPlaneAngleMeasure HOT 2
- IfcLogical representation in XML base HOT 1
- IMPROVEMENT: functionality to point towards bSDD (data dictionaries) HOT 4
- IDS BIM
- Restriction of values: Enumeration limited to string-based datatype or do we allow for real, integer and measurements HOT 3
- Predefined type evaluation
- userdefuned HOT 6
- Test case naming consistency HOT 2
- 2 testcases have .html file instead of .ifc HOT 2
- Tolerance documentation 1.0.0 HOT 6
- Wrong file name in the entity directory of test cases HOT 1
- Tolerance test issues in 1.0 HOT 3
- Are complex restrictions applicable to all facet parameters? HOT 2
- Test case for indirect containment is incorrect
- Relation between enumerations in Applicability and Requirements HOT 1
- Broken links on dev Readme
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ids.