Comments (6)
We are trying to move away from user-defined types (and in IFC 5 even from predefined-types).
Best practise is to use/add a classificationreference to the IFC class to further specify it.
The best-practise guidelines for IDS might change in 1.1 to reflect this movement.
from ids.
Quite right, I'll address that, apologies.
from ids.
The ids file in test case is probably wrong, the tag:
<predefinedType>
<simpleValue>USERDEFINED</simpleValue>
</predefinedType>
must be replaced with:
<predefinedType>
<simpleValue>WALDO</simpleValue>
</predefinedType>
from ids.
The ids file in test case is probably wrong, the tag:
<predefinedType> <simpleValue>USERDEFINED</simpleValue> </predefinedType>
must be replaced with:
<predefinedType> <simpleValue>WALDO</simpleValue> </predefinedType>
I think the test is right. What's the requirement is trying to test is that the entities have a PreDefinedType of USERDEFINED - but we don't want to check the specific user-defined type provided in ObjectType/ElementType etc.
i.e. we're checking for .USERDEFINED.
not WALDO
There are separate test cases that test for checking specific User Defined Type values etc. e.g. pass-a_predefined_type_may_specify_a_user_defined_object_type.ids and fail-user_defined_types_are_checked_case_sensitively.ids
from ids.
To check the predefined type attribute, we could test this way:
<requirements>
<attribute>
<name>
<simpleValue>PredefinedType</simpleValue>
</name>
<value>
<simpleValue>WALDO</simpleValue>
</value>
</attribute>
</requirements>
from ids.
Best practise is to use/add a classificationreference to the IFC class to further specify it.
Agreed - When everything is classified that's where Classification Facets come in of course.
To check the predefined type attribute, we could test this way:
[using an attribute facet]
Presumably with :
...
<value>
<simpleValue>UNDEFINED</simpleValue> <!-- rather than WALDO-->
</value>
While this may work, it's worth noting that I believe the Entity Predefined Type logic should check the DefiningType as well as the instance. So for instance in IFC2x3 an IFCWALL has no PredefinedType - it's on the IFCWALLTYPE. So you may get subtle differences accessing via Attribute facet
from ids.
Related Issues (20)
- IDS BIM
- Restriction of values: Enumeration limited to string-based datatype or do we allow for real, integer and measurements HOT 4
- Predefined type evaluation
- Test case naming consistency HOT 2
- 2 testcases have .html file instead of .ifc HOT 2
- Tolerance documentation 1.0.0 HOT 7
- Wrong file name in the entity directory of test cases HOT 1
- Tolerance test issues in 1.0 HOT 5
- Are complex restrictions applicable to all facet parameters? HOT 2
- Test case for indirect containment is incorrect
- Relation between enumerations in Applicability and Requirements HOT 2
- Broken links on dev Readme HOT 1
- Add textual definitions to each IDS element HOT 2
- IfcTester check ifc version?
- Proposal: Permit dataType equivalents for non-measure Property values HOT 4
- IfcAlignmentTypeEnum in IFC4 HOT 2
- IDS master branch has disappeared HOT 8
- Documentation Readme references missing example/sample files HOT 1
- Repo housekeeping HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ids.