build2-packaging / args Goto Github PK

I've noticed that the submitted package (and CI requests before that) took excessively long to link with MinGW GCC causing our build bots to timeout.

Could you exclude this configuration from building?

You've added a package-specific README, which is great! (I also assume you will add package-description-file mentioning it on the next release).

But I think all this installation under different names is unnecessarily complicated. Here is the recommended setup:

1. Call upstream README just README.md and call package README either PACKAGE-README.md or README-PACKAGE.md.

2. List them in manifest:

description-file: README.md
package-description-file: PACKAGE-README.md

3. Install them just like that from the root buildfile:

./: ... doc{README.md PACKAGE-README.md}

I noticed that the tests for this library use bundled catch.hpp. This is not ideal (but not a deal breaker either) since we have catch2 as a package (we even have the exact version that is bundled, if this is important for some reason).

Note that switching to the external catch2 will requite factoring tests into a separate package (args-tests) which in turn will require turning this into a multi-package repository. I also see test.cxx includes the header without the <catch2/> prefix. This can be solved by replacing the upstream catch.hpp with a wrapper that simply includes the external header.