bu-isciii / iskylims_drylab Goto Github PK

View Code? Open in Web Editor NEW

2.0 4.0 5.0 5.09 MB

Python 38.51% CSS 25.70% JavaScript 12.68% HTML 23.12%

django-project iskylims lims ngs ngs-data

iskylims_drylab's Introduction

BU-ISCIII

Our Wiki and main public documentation repository.

https://github.com/BU-ISCIII/BU-ISCIII/wiki

iskylims_drylab's People

Contributors

Stargazers

Watchers

Forkers

saramonzon gerritbostelmann miguelsqdro pilarnatividad samlex20

iskylims_drylab's Issues

Front page statistics

Table with services recorded, resolved, queued and in progress.

Service statistics / requested by user - error with inexistent users

When filling in "Form for getting User statatistics", if User Name is an inexistent one, the application emits an error (UnboundLocalError at /drylab/statsByDateUser)

Problem in generation of pdf with images

Warning in httpd log that could be related:
[Wed Jun 20 17:18:36 2018] [error] [client 10.15.60.49] File does not exist: /srv/iSkyLIMS/static/iSkyLIMS_common_static/vendor/swiper/js/maps
[Wed Jun 20 17:18:44 2018] [error] [client 10.15.60.49] /srv/iSkyLIMS/virtualenv/lib/python3.6/site-packages/weasyprint/text.py:28: UserWarning: There are known rendering problems with Cairo <= 1.14.0, referer: http://flavia.isciii.es/drylab/service_request_internal_sequencing
[Wed Jun 20 17:18:44 2018] [error] [client 10.15.60.49] warnings.warn('There are known rendering problems with Cairo <= 1.14.0'), referer: http://flavia.isciii.es/drylab/service_request_internal_sequencing
[Wed Jun 20 17:18:45 2018] [error] [client 10.15.60.49] /srv/iSkyLIMS/virtualenv/lib/python3.6/site-packages/weasyprint/fonts.py:43: UserWarning: @font-face support needs Pango >= 1.38, referer: http://flavia.isciii.es/drylab/service_request_internal_sequencing
[Wed Jun 20 17:18:45 2018] [error] [client 10.15.60.49] warnings.warn('@font-face support needs Pango >= 1.38'), referer: http://flavia.isciii.es/drylab/service_request_internal_sequencing
[Wed Jun 20 17:18:46 2018] [error] [client 10.15.60.49] File does not exist: /srv/iSkyLIMS/static/iSkyLIMS_common_static/vendor/swiper/js/maps

Drylab/manage services/pending services: Information about status "approved" seems to be useless for user (after introduction of the request, this is in state 'recorded' and, next, it passes to 'queued' or is 'rejected')

Ponder whether to purge it from the information provided to the user (the "list of services in Approved State" and within the pie chart graph)

Counseling request: field 'serviceUserId' was not excluded in form.py

serviceUserId excluded in form.py

Issues with Consulting Service Request Form

You cannot save a form without uploading a file.

Same problem with checkboxes as in Service Request.

Drylab/services statistics/services requested: repeted graphs?

when asking for statistics for a given user, there seems to be two instances of each of the following graphs in the provided information:
-service requested by center
-service requested by area

Ponder to choose one representation of each and dump the other.

Access to "resolution form for Service" from a "delivered" service

When pulling information from menu manage services >> search service, about service "SRVCNM081",
the "display service" view includes on the right hand side a pannel named "Allowed actions on SRVCNM081" with a button "Add resolution" underneath.
Clicking on that button leads to the following formulaire.
Does it makes sense if the service has been already delivered?

(BLOCKS access to DRYLAB) Attribute error at /drylab/: 'NoneType' object has no attribute 'strftime'

Traceback:

File "/srv/iSkyLIMS/virtualenv/lib/python3.6/site-packages/django/core/handlers/exception.py" in inner
35. response = get_response(request)

File "/srv/iSkyLIMS/virtualenv/lib/python3.6/site-packages/django/core/handlers/base.py" in _get_response
128. response = self.process_exception_by_middleware(e, request)

File "/srv/iSkyLIMS/virtualenv/lib/python3.6/site-packages/django/core/handlers/base.py" in _get_response
126. response = wrapped_callback(request, *callback_args, **callback_kwargs)

File "/srv/iSkyLIMS/virtualenv/lib/python3.6/site-packages/django/contrib/auth/decorators.py" in _wrapped_view
21. return view_func(request, *args, **kwargs)

File "/srv/iSkyLIMS/drylab/views.py" in index
44. service_delivery_date = Resolution.objects.filter(resolutionServiceID = service).last().resolutionEstimatedDate.strftime("%d %B, %Y")

Exception Type: AttributeError at /drylab/
Exception Value: 'NoneType' object has no attribute 'strftime'

allow to attach file names with acens and spaces when creating a new service

When user attach a file where the filename has special characters like accents or spaces, the file cannot be saved UTF-8 characters.

"Field 'serviceUsername_id' doesn't have a default value"

When the creating a new service . /drylab/service_request_internal_sequencing'
Error page is showed with :
"Field 'serviceUsername_id' doesn't have a default value"

Coded unprotected

Resolution object doesn't exit when first if in the function doesn't exit, protect the code so no ugly error is prompted to the user.

iSkyLIMS_drylab/models.py

Line 150 in c54fbb1

estimated_date = resolutions.resolutionEstimatedDate.strftime("%d %B, %Y")

Creating new account issues

If you submit an incorrect new account form, there is a broken link to the image it is supposed to be shown. Happened when "passsword1 != password2".

Also, passwords requisites include "Your password can't be a commonly used password" and "Your password can't be too similar to your other personal information". Is this being checked at all? Dummy passwords as "password1234" are still accepted.

allow user to create their own closer user group

whit this new feature, user can request a new service on behalf any member of the team

- [ ] Multiple select run projects in Service Genomics Unit form.

Download data service requests also ask you to upload your data

Feature - Admin privileges: view with services recorded and in progress.

Form for resolution. Recorded services go to form for save all information in resolution model. Once resolved, service pass to state approved or rejected, mail is sent to user and service pass to queued state.
Queued services can be selected and change state to in progress.
Queued services can be selected for delivery and form for delivery model fields can be completed. Mail is sent to user with all the information.

Add service_external_request in views

Add functionality for external sequencing service request, in dropdown EXTERNAL SEQUENCING Sequencing Center must be selected.

drylab/service statistics/samples processed: error when processing time frame

If start date = 01/01/2017 and end date= 01/01/2018, error: ValueError at /drylab/statsBySamplesProcessed

Feature: Mail to user and admin when new service requested.

Service selection checkboxes

You can uncheck checkboxes of the subdirectories containing your request. Would the service request work anyway?

#Statistics

Services requested by date and by user (StartDate, EndDate, User) Shows all services order by the user
Services ordered by users (StartDate, EndDate) Shows services per user
Services completed, ongoing, not started (StartDate , EndDate) Shows all services and their state

More to go

Issues modifying account details

Same broken link image as when creating new account.

When modifying your account details, you are asked to modify your password too.

Old password can be updated to the same password. This can be a security issue if in the future users are asked to change their passwords periodically or after a security breach.

After modifying your account details, you are not redirected to the previous page, nor the home page.

After modifying your account details, you are automatically logged out.

conected users , last time loging
[ ]