brunobar79 / eth-commerce

Javascript library to accept ethereum payments on any website

eth-commerce's Issues

Update the total amount

Feature Request

Hey. Excellent script. I would like to use it in an Online Shop for Checkout.
I kinda hacked it in a way that now I remove and regenerate the DOM object of the button each time the value changes by calling this custom function:

var extCurrency = 'EUR';

function addMetaMask() {
  if ($('#metamask-checkout').length) $('#metamask-checkout').remove();
  // create div
  $('<div/>')
    .addClass('eth-commerce-button')
    .attr('id', 'metamask-checkout')
    .appendTo("div.widget");

  // turn it into an ETHCommerce button
  var ethCommerce = new EthCommerce();
  ethCommerce.render(
  {
      targetElement: 'metamask-checkout',
      type: 'PAY',
      amount: $('span.ct-cart-total').text().replace(/\D/g,''),
      currency: extCurrency,
      address: '0x11A7Ca870700f284e4647E55DeD9040f0F86D4D4'
  }, (e)=>{
      console.log('error callback', e);
  },(tx)=>{
      console.log('success callback', tx);
  });
}

It would be cool if your class had a function to update the amount in a more elegant way.

Amount not passed to MetaMask

Hey there, I just noticed that the button doesn't seem to pass the amount to MM anymore. I found a little error in the function getEtherPriceIn. It sends a POST request where it should be GET. Now it works.

  getEtherPriceIn(currency) {
    return new Promise((resolve, reject) => {
      fetch(
        `https://min-api.cryptocompare.com/data/price?fsym=ETH&tsyms=${currency}&sign=true`,
        {
          method: "GET", // <----------------------------------------
          mode: "cors"
        }
      )
        .then(response => response.json())
        .then(data => {
          resolve(data[currency]);
        })
        .catch(e => {
          reject(e);
        });
    });
  }