Coder Social home page Coder Social logo

Comments (3)

rodmjay avatar rodmjay commented on July 20, 2024

so what you are saying is that there will always be a username, but in the case of EmailIsUsername it would be a guid, correct?

from brockallen.membershipreboot.

brockallen avatar brockallen commented on July 20, 2024

I want to accommodate the "email is username" option but also allow for user's to change their email address. Currently when an account is created the username is just assigned from the email, so if at any point they change their email then the nameidentifier claim will have the old email which will look odd if/when the email is changed.

If we use a GUID (or something else like it) then what we'll have is a nameidentifier like tenant:guid, a email and name claims which match the current email.

The other change this entails is that when authenticating if the app has set the "email is username" option, then we'll have to load the account by email (not username). This is an internal detail, but I note it here for completeness.

This shouldn't break anything and shouldn't require any DB changes when upgrading (one the feature is done) as long as the app has been relying upon the nameidentifier claim for a unique ID for the account (or the int PK if you've been doing it at the DB level).

from brockallen.membershipreboot.

brockallen avatar brockallen commented on July 20, 2024

I think this will assuage my concern: 943dc84

from brockallen.membershipreboot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.