ChangeEmailRequest should change username in case of EmailIsUsername and not RequireAccountVerification about brockallen.membershipreboot

[brockallen]

IIRC we don't want to trust the new email until the new email has been confirmed. If you change it prior to that then the account is in an inconsistent state.

[HenkHui]

Thanks for the quick response Brock.
The e-mail is changed and the account state is set to not verified:

if (!Configuration.RequireAccountVerification)
{
Tracing.Verbose("[UserAccountService.ChangeEmailRequest] RequireAccountVerification false, changing email");
account.IsAccountVerified = false;
account.Email = newEmail;
this.AddEvent(new EmailChangedEvent { Account = account, OldEmail = oldEmail, VerificationKey = key });
Update(account);
}
else
{
Tracing.Verbose("[UserAccountService.ChangeEmailRequest] RequireAccountVerification true, sending changing email");
this.AddEvent(new EmailChangeRequestedEvent { Account = account, OldEmail = oldEmail, NewEmail = newEmail, VerificationKey = key });
UpdateInternal(account);
}

So the state of the account is the same as it would be when you created it with the RequireAccountVerification set to false, however the only thing off is the username.

Even more, the state of the account is now inconsistent because the username and the e-mailaddress are not the same despite of setting EmailIsUsername to true.