Coder Social home page Coder Social logo

why enforce lowercase? about tangram HOT 4 OPEN

broadinstitute avatar broadinstitute commented on June 7, 2024
why enforce lowercase?

from tangram.

Comments (4)

Hejin0701 avatar Hejin0701 commented on June 7, 2024 1

Hi @giovp ,

Thanks for your suggestion! The initial purpose of these two lines of commands are to get rid of the inconsistent capitalization of gene name. You are right, it is not always needed and thus it is better to make it optional.

I have just updated Tangram function pp_adatas with an additional parameter gene_to_lowercase. The default value is set as True. If not needed, people can alway set it as False to prevent conversion of the genes names to lower cases. One additional line of instructions is added before the pp_adatas function in tutorial.

from tangram.

giovp avatar giovp commented on June 7, 2024

thank you!

from tangram.

yinan-wan0 avatar yinan-wan0 commented on June 7, 2024

Hi,

It looks like this enforcing lower case was not only in pp_adatas, but also in tg.project_genes. After running it my sc_adata genes become all lower case. Can you please also provide an option to disable it there?

Thanks a lot!

from tangram.

giovp avatar giovp commented on June 7, 2024

Indeed! that's really problematic and give rise to all sorts of issues, am reopening this cause the issue is not resolved

The initial purpose of these two lines of commands are to get rid of the inconsistent capitalization of gene name

I would also like to mention that there is no reason that such inconsistency should be resolved inside the method call, especially without throwing any warning.

from tangram.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.