Coder Social home page Coder Social logo

Comments (4)

bacongobbler avatar bacongobbler commented on May 27, 2024

Comment by technosophos
2017-10-10 20:58:59


I would strongly prefer that this is a configurable thing via the Project.

from brigade.

technosophos avatar technosophos commented on May 27, 2024

We implemented a specific fix for the GitHub gateway. Might still be a way to do a general fix.

from brigade.

technosophos avatar technosophos commented on May 27, 2024

So I think the general design of this would be to add an attribute on the event that was something like trusted: false. The Worker's index.ts would then wipe out the project.secrets.

But the problem is that the worker can still manually load the project and bypass the taint. So really this doesn't get us much more than a band-aid.

from brigade.

krancour avatar krancour commented on May 27, 2024

Closing due to staleness. Please do re-open if appropriate.

from brigade.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.