Comments (9)
Oh, the problem seems to exist in many of the actions. Should I try to find all possible places where that may exist and fix them?
from brigade.
Btw can I work on this issue? I have end-semester exams throughout the next week, still can try to manage some time. If that doesn't get possible then shall fix it once it's over.
from brigade.
the problem seems to exist in many of the actions. Should I try to find all possible places where that may exist and fix them?
That would be great. To help narrow it down, I think all such places would be project-related.
from brigade.
Do I need to check for the READER role before informing that the project doesn't exist? I was thinking of doing that after project creation attempt fails only (i.e. towards the end of the function).
I have observed that if opts.CreateIfNotFound is set to false, user is already being informed about non-existence of project without checking for READER role.
from brigade.
By having a look at the Update function, it seemed to me that project-authorization attempt in case of a non-existing project is leading to authorization error. Haven't studied the Authorize function of project authorizer properly yet, as it involves principal and some other stuff which I am not aware at this moment.
from brigade.
Forgive me... I haven't looked yet, but is the root cause of the issue not identical to #1893?
from brigade.
Oh yeah, most probably they are indeed. I sadly was unnecessarily focusing on the -c flag.
Anyway will fix it within today.
from brigade.
Btw I wanted to mention that use of tilt with ctlptl made the hacking experience really awesome.
from brigade.
Btw I wanted to mention that use of tilt with ctlptl made the hacking experience really awesome.
So happy to hear that! It's been a major focus lately to try to make it as easy as possible to work on this.
from brigade.
Related Issues (20)
- Add instrumentation to give insight into API request volume
- CI/CD: Wait for Docker port to be open HOT 6
- bug: InvalidImageName not handled correctly
- Update homebrew formula for v2.4.0 HOT 3
- bug: wrong error creating event for project that doesn't exist HOT 3
- Brigade 2.x - Support for PVCs in jobs HOT 4
- bug: if worker uses shared workspace, it's mounted read only, but shouldn't be
- Need support for adding security context HOT 7
- bug: new git-initializer cannot check out specific commits that aren't in the default branch HOT 1
- git-initializer component does not work with repos hosted on Azure DevOps HOT 2
- docs home page needs updating HOT 2
- bug: if -c flag is set on `brig project update`, we're not checking for create permission HOT 2
- token auth filter should not be picky about case of word "Bearer" in auth header
- implement a strategy for testing against a live database
- check for whether new user should be an admin should be case insensitive HOT 1
- Readnext documentation page bad links
- Fix [Brigade Developers Guide] Link on topics/index docs page
- Brigade is now a CNCF Archived project: update website, etc HOT 4
- Netlify: select a new build image HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brigade.