brick / reflection Goto Github PK

When parameter has no type, the exportFunction method assigns a nullable sign on the parameter.
Example:

is exported as:

To resolve the issue, you should move the verification for nullable parameters, so this verification is placed inside the verification for the parameter type:

Before my proposed modification:
// File: ReflectionTools.php(324)

if ($parameter->allowsNull() && ! $parameter->isDefaultValueAvailable()) {
    $result .= '?';
}

if (null !== $type = $parameter->getType()) {
    if (! $type->isBuiltin()) {
        $result .= '\\';
    }

    $result .= $type->getName() . ' ';
}

After my proposed modification:
// File: ReflectionTools.php(324)

if (null !== $type = $parameter->getType()) {
    if ($parameter->allowsNull() && ! $parameter->isDefaultValueAvailable()) {
        $result .= '?';
    }

    if (! $type->isBuiltin()) {
        $result .= '\\';
    }

    $result .= $type->getName() . ' ';
}

I hope I made myself clear with my not-so-good English. But if you have any doubts, we could talk more.
And I thank you for the great tool you made, it saved me hours of development of a function to export a ReflectionFunction signature.

in this example:

use Brick\Reflection\ImportResolver;

$class = new ReflectionClass(App\Test::class);
$resolver = new ImportResolver($class);

echo $resolver->resolve('\Some\FQCN\Class'); // Some\FQCN\Class
echo $resolver->resolve('Something'); // App\Something
echo $resolver->resolve('Something\Else'); // App\Something\Else
echo $resolver->resolve('Bar'); // Foo\Bar
echo $resolver->resolve('Bar\tender'); // Foo\Bar\tender
echo $resolver->resolve('Alias'); // Foo\Bar\Baz
echo $resolver->resolve('Alias\ooka'); // Foo\Bar\Baz\ooka

you are using a string of the declared class: App\Test::clas

Can you extend your class to parse objects in which the instance of a class is stored?

$class = new ReflectionClass($classObject);