Comments (3)
BenMorel
commented on September 16, 2024
1
LGTM as well with the Native prefix. @solodkiy You're welcome to open a PR to create the new (to|from)Native*() methods, and deprecate existing ones. We'll remove them in 0.5.0.
The getDateTime() method is in line with the discussion we had in #48, so it looks good as it is!
from date-time.
tigitz
commented on September 16, 2024
IMO, the Native prefix makes sense, I'm 👍 on this it helps readability and reduce ambiguity. I've wondered myself while trying to autocomplete method calls if the suggested DatePeriod for example was a library class or the native one.
However I would keep the getDateTime as it is since it means it is getting the DateTime part of the ZonedDateTime. Using the to prefix would suggest it's transforming the object into another one which is not the case here.
@BenMorel wdyt ?
from date-time.
solodkiy
commented on September 16, 2024
Some of get*()/to*() discussion was there: #48
from date-time.
Related Issues (20)
- Discussion: ISO8601/RFC3339 time + timezone class HOT 1
- ZonedDateTime::{plus,minus}{Minutes,Hours,Seconds} behaves differently to Java 8 HOT 2
- Instant::toISOString() is not RFC 3339 compliant HOT 2
- LocalDate::utc() method
- Add DayOfMonth type
- LocalDate::now($timezone /*= system TimeZone*/) HOT 1
- `Interval` is so barebones compared to `LocalDateRange`
- Add Seconds value object HOT 3
- Interface for any object representing an interval of time HOT 8
- Some objects with ISO representations are missing a parse method
- LocalDateRange / endExclusive HOT 6
- Negative Duration HOT 2
- `null`-friendly methods HOT 13
- [performance] Optimizing LocalDate::plusDays() method HOT 1
- Performance optimization: skip validation when creating objects (SOLUTION: use Reflection) HOT 8
- Broken badge on README HOT 2
- Year::toISOString() not conformation to ISO 8601 HOT 2
- Add `DefaultClock::travelForwards(Duration)` HOT 4
- `LocalDate::parse(...)` does not recognise ISO-8601 HOT 1
- Year::atMonth() should accept a Month HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from date-time.