Comments (2)
Just to be clear:
public function plusPeriod(Period $period): ZonedDateTime
{
return ZonedDateTime::of($this->localDateTime->plusPeriod($period), $this->timeZone);
}
public function plusDuration(Duration $duration): ZonedDateTime
{
return ZonedDateTime::ofInstant($this->instant->plus($duration), $this->timeZone);
}
Change behavior is happening only when timezone changes between two points of time (like DST).
from date-time.
Hi @JanTvrdik,
I wasn't aware of this difference between brick/date-time and java.time, thanks for bringing it to my attention!
I think it's totally reasonable to expect this to work the same way as it does in Java, so let's consider this a bug report. I'll see if I can find some time to work on this in the coming days, unless you want to open a PR.
However, as this is a BC break, it will require a new version bump (0.8.0), as version 0.7.0 was released just 2 days ago.
from date-time.
Related Issues (20)
- `Interval` is so barebones compared to `LocalDateRange`
- Add Seconds value object HOT 3
- Interface for any object representing an interval of time HOT 8
- Some objects with ISO representations are missing a parse method
- LocalDateRange / endExclusive HOT 6
- Negative Duration HOT 2
- `null`-friendly methods HOT 13
- [performance] Optimizing LocalDate::plusDays() method HOT 1
- Performance optimization: skip validation when creating objects (SOLUTION: use Reflection) HOT 8
- Broken badge on README HOT 2
- Year::toISOString() not conformation to ISO 8601 HOT 2
- Add `DefaultClock::travelForwards(Duration)` HOT 4
- `LocalDate::parse(...)` does not recognise ISO-8601 HOT 1
- Year::atMonth() should accept a Month HOT 3
- Discussion: ISO8601/RFC3339 time + timezone class HOT 1
- Instant::toISOString() is not RFC 3339 compliant HOT 2
- LocalDate::utc() method
- Add DayOfMonth type
- LocalDate::now($timezone /*= system TimeZone*/) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from date-time.