Coder Social home page Coder Social logo

Comments (2)

solodkiy avatar solodkiy commented on August 12, 2024 1

Just to be clear:

public function plusPeriod(Period $period): ZonedDateTime
{
    return ZonedDateTime::of($this->localDateTime->plusPeriod($period), $this->timeZone);
}

public function plusDuration(Duration $duration): ZonedDateTime
{
    return ZonedDateTime::ofInstant($this->instant->plus($duration), $this->timeZone);
}

Change behavior is happening only when timezone changes between two points of time (like DST).

from date-time.

BenMorel avatar BenMorel commented on August 12, 2024

Hi @JanTvrdik,

I wasn't aware of this difference between brick/date-time and java.time, thanks for bringing it to my attention!

I think it's totally reasonable to expect this to work the same way as it does in Java, so let's consider this a bug report. I'll see if I can find some time to work on this in the coming days, unless you want to open a PR.

However, as this is a BC break, it will require a new version bump (0.8.0), as version 0.7.0 was released just 2 days ago.

from date-time.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.