brick / date-time-doctrine Goto Github PK

Hey @BenMorel thank you for this package. I always use this library for my entities, and I always made the types myself. I'm going to switch to this one, so thank you a lot for making it available.

I just have one question. Why not a ZonedDateTimeType? I understand this could be due to some databases not supporting timezones in their datetime types, but we could always convert it to utc prior to storage, right?

Please correct me if I'm wrong.

Is there any reason why this package wouldn't work OOTB with ORM 3.0 and DBAL 4.0, as it seems to support ORM 2.19? Can we just "or" the versions in composer.json?

Hi @BenMorel,
thanks a lot for your work and this library.

During my last development I noticed that the names you used for Doctrine types is different from the Doctrine DBAL standard naming.
In the Doctrine official library the types are named this way:

[...]
    public const DATE_IMMUTABLE       = 'date_immutable';
    public const DATEINTERVAL         = 'dateinterval';
    public const DATETIME_MUTABLE     = 'datetime';
    public const DATETIME_IMMUTABLE   = 'datetime_immutable';
    public const DATETIMETZ_MUTABLE   = 'datetimetz';
    public const DATETIMETZ_IMMUTABLE = 'datetimetz_immutable';
[...]

while in your library you use the camelCase notation:

[...]
final class LocalDateTimeType extends Type
{
    public function getName(): string
    {
        return 'LocalDateTime';
    }
[...]

Can I ask you why? Would you consider to change this if I open a pull request for this change?

Hope to hear from you soon