brianrobles204 / music-integration Goto Github PK

Hi, could you add VLC player to supported players ?

Thank you

JS ERROR: Extension music-integration@brianrobles204: ImportError: No JS module 'dbus' found in search path @/usr/share/gnome-shell/extensions/music-integration@brianrobles204/extension.js:4:14
gnome-shell --version
GNOME Shell 3.38.1

I made a very small patch (2 lines) that attribute an icon to the configuration window, and removes a useless and confusing entry in the combobox.
I don't know how to add a patch on github, so I'm pasting it here :
--- music-int-pref.py.old 2011-12-05 15:54:51.592340855 +0100
+++ music-int-pref.py 2011-12-05 15:54:36.535431011 +0100
@@ -11,6 +11,7 @@
window = Gtk.Window()
window.connect('destroy', lambda w: Gtk.main_quit())
window.set_title('Music Integration Preferences')

•    window.set_icon_name(Gtk.STOCK_PREFERENCES)
   window.set_default_size(400, 160)  
   window.set_border_width(6)
  

@@ -46,7 +47,6 @@
player = Gtk.ComboBoxText()

     hplayerbox.pack_start(player, False, True, 0)

•    player.append_text('Choose a setup :')
   player.append_text('Player as Indicator in Panel')
   player.append_text('Player in Volume Menu')
   player.append_text('Notifications only')
  

I thought there was a bug for this but since I don't see it:

When setting the Preferences>Notification option to Off, the setting is only temporary and is reset to the On status whenever the shell is restarted or the system reboot, etc, and the message tray indicator is indeed back from the grave. It isn't the end of the world, but the setting is useless in the current state.

I've tested the extension thoroughly under gnome-shell 3.3.2, everything works as expected. I recommend bumping the compatible shell versions in metadata.json to include all versions up to and including 3.3.2.

The buttons of the pop up menu, on the panel as well as on the tray are not displaying at their full size. This bug started after I followed your instructions to turn on the preferences.

http://ubuntuone.com/0x3ulPIDAlwtNNb0uR2cZE

Gnome 3.2, ubuntu 11.10, Spotify for linux; the volume controller is broken

because it uses a mix of spaces and tabulation.
To fix it, I opened music-int-pref.py with gedit, activated plugin “show blankspace” plugin (actual name might be a little different, I'm not using English locale), then selected a tabulation, and use “Search and replace” to replace all tabulations by 8 spaces.
You can also, by the way, add python-gobject to the list of dependancies.

I am trying to use this extenstion on Gnome-shell 3.4 but it is not compatible

Covert art shows on Rhythmbox, but not on the extension indicator when playing music from Last.FM plugin (cover art fetched via CoverArt plugin).

It works with local music even if cover art just get fetched by the CoverArt plugin.

Rhythmbox started sttuteting on some songs. I first though it was because of enabling the "ReplayGain" plugin, but it's the same when disabled. If I disable this extension, the music sounds perfect.

So this is a pretty important problem, if the extension it's really the cause. Has anyone experienced this?

For example, when the user press Ctrl + Alt + m, show the notification with the currently playing music.

That is a good feature, at least for me that don't like be disturbed with the notification after each song.

Hope you find it useful too. The key binding could be enabled/disabled by a setting.

Thanks!

The PLayer as Indicator in Panel option provides options that seem like they should also be available in the Player in Volume Menu option.

For instance in the Indicator mode, e.g indicator in top panel(NOT messagetray), you would see Music Volume, and Shuffle & Repeat toggle switches, whereas in Voume Menu mode you do not.

The Preferences option could also be a button as it appears in the messagetray indicator, but I understand how that part could be confusing.

I'm using Archlinux up-to-date (gnome 3.2)
I installed the package through extensions.gnome.org and then followed the instructions given on github.
I now have a "Music preference" item above "Sound Settings" but nothing happens when I click it.

If Rhythmbox "Notification" plugin is enabled (which is the default), notifications get duplicated (well, one is from Rhythmbox and the other from the extension).

You can manually disable the Rhythmbox notification plugin and just get the ones from the extension.

When running with mpDris2, adjusting the volume is broken:

CommandError: [52@0] {setvol} problems setting volume
JS LOG: Ignored exception from dbus method: Error: DBus error: org.freedesktop.DBus.Python.mpd.CommandError: Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/dbus/service.py", line 702, in _message_cb
retval = candidate_method(self, _args, *_keywords)
File "./mpDris2", line 414, in Set
setter(value)
File "./mpDris2", line 345, in __set_volume
mpd_wrapper.setvol(int(value * 100))
File "/usr/lib/python2.7/dist-packages/mpd.py", line 167, in
return lambda *args: wrapper(command, args)
File "/usr/lib/python2.7/dist-packages/mpd.py", line 213, in _execute
return retval()
File "/usr/lib/python2.7/dist-packages/mpd.py", line 312, in _fetch_nothing
line = self._read_line()
File "/usr/lib/python2.7/dist-packages/mpd.py", line 233, in _read_line
raise CommandError(error)
CommandError: [52@0] {setvol} problems setting volume

I thought this might be easy to impliment but alas I am still not experienced enough, at any rate some of the code from this commit seems very similair, and perhaps they used your work and built upon it, either way it should be easy enough to impliment, hopefully in the indicator and in the messagetray

linuxmint/cinnamon@315c002

I installed the extension from gnome's site, the icon does not appear in the panel.

I have the following issue in Archlinux with Gnome GNOME Shell 3.2.1:

There is no player icon displayed both in tray and in the volume menu. Instead of player icon (I use Banshee as my audio player) there is a "missing icon". I tried with different themes and all of them have the same problem. A also tried version from extensions.gnome.org, from your GitHub, tried to install this extension as user and as root - nothing is changed.

Thank you in advance.

Please consider adding the ability to change the rating of the songs. Also it would be nice to see the rating of the present song on the panel.

Hi,

Audacious 2.3 released with MPRIS 2 support: http://audacious-media-player.org/news/7-audacious-3-2-released

Should work now.

Thanks in advance!