Coder Social home page Coder Social logo

breadwallet-ios's Introduction

ƀ breadwallet

download

bitcoin done right

The simplest and most secure bitcoin wallet on any platform

screenshot1

The first standalone iOS bitcoin wallet:

Unlike other iOS bitcoin wallets, breadwallet is a real standalone bitcoin client. There is no server to get hacked or go down, so you can always access your money. Using SPV mode, breadwallet connects directly to the bitcoin network with the fast performance you need on a mobile device.

The next step in wallet security:

breadwallet is designed to protect you from malware, browser security holes, even physical theft. With AES hardware encryption, app sandboxing, keychain and code signatures, breadwallet represents a significant security advance over web and desktop wallets, and other mobile platforms.

Beautiful simplicity:

Simplicity is breadwallet's core design principle. A simple backup phrase is all you need to restore your wallet on another device if yours is ever lost or broken. Because breadwallet is deterministic, your balance and transaction history can be recovered from just your backup phrase.

screenshot2

Features:

Translations managed by:

PhraseApp - Start localizing software the simple way

URL scheme:

breadwallet supports the x-callback-url specification with the following URLs:

bread://x-callback-url/address?x-success=myscheme://myaction

This will callback with the current wallet receive address: myscheme://myaction?address=1XXXX

The following will ask the user to authorize copying a list of their wallet addresses to the clipboard before calling back:

bread://x-callback-url/addresslist?x-success=myscheme://myaction

WARNING:

Installation on jailbroken devices is strongly discouraged.

Any jailbreak app can grant itself access to every other app's keychain data and rob you by self-signing as described here and including <key>application-identifier</key><string>*</string> in its .entitlements file.


breadwallet is open source and available under the terms of the MIT license.

Source code is available at https://github.com/voisine/breadwallet

breadwallet-ios's People

Contributors

acorscadden avatar brd-jwheeler avatar brdcryptoray avatar davidsights avatar drewcarlson avatar dts avatar ewerx avatar gutyn avatar jmacwhyte avatar losh11 avatar noelralex avatar rrrrray avatar samuraisam avatar spokzcycling avatar voisine avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

breadwallet-ios's Issues

Bitcoin Cash send dialog shows Bitcoin's USD rate

I was sending a Bitcoin Cash payment and the bits/USD button worked as expected. 17,000 bits, $12, sure. Close enough. Then pressing send, it says 17,000 bits and $130, clearly using Bitcoin's price and not Bitcoin Cash's price after pressing send from within the first send dialog.

When I sent the transaction, it showed the correct dollar amount in the transactions list.

Let me know if this makes sense. I got it a couple times so hopefully it's not entirely intermittent.

Thanks!

How to get private key?

// WIF private key

In the code I have seen Work-In-Progress for fetching private key. Is it In progress?
or Is it completed?
Please let me know can I use this library code for following:

  1. Crating and fetching private key?
  2. Can I use the library code for Singapore based wallet app?
  3. Can I buy bitcoin/ethereum in Singapore.
  4. Can I use for transaction creation for cryptocurrency?

About customs fees.

Many wallets even when the mempool is not full calculate the expensive rate to confirm faster but I know that if I pay a cheaper fee I know how long it can take to confirm on the network through network fee comparator bitcoin that shows all the fees from 0 sat/byte to 1000 sat/byte and the maximum confirmation time, I know the risk of putting a fee low too, my transaction will be stuck in mempool for an indeterminate time, but I also know that some algorithms of wallets calculate the fee out of the ordinary, most more expensive than the network asks that is the case of this wallet, add a warning when the user clicks on custoo fee saying that if he places a fee too low then the network asks, your transaction can be stuck indefinitely, that alone is enough, upon reading this warning the risk is the user.

Ideas...

a) add more network fee options, low / low-med / med / med-high / high (at least 5)
b) implement a slider that lets the user select the max time he is willing to wait by estimating the size and using bitcoinfees.earn.com to estimate the times. the slider should have at least 5 steps 1h / 2h / 6h / 12h / 24h
c) let advanced users configure the values for low / med / high priority
d) change the raise network fee option to really raise the fee by a selectable amount or rename it

Custom Fees

I like being given two options for fees. But it would be great to have a middle option or a custom option. Yesterday, I was given the choice between $20 and $1.43. Big difference.

Not able to compile

I am trying to compile the source code but i am struck at here. Please reply asap and let me know if anything required from my side. Thanks in advance.

screen shot 2018-04-19 at 4 51 34 pm

When rates fail, tx sending fails

If both rates APIs fail, transaction sending fail. Not only this, transaction information is also hidden from the user + bitcoin balances displayed as 0. It'd be nice if the app could be protected from such an issue.

There's two points of failure here, and if an ISP/country blocks two domains (api.breadwallet.com | bitpay.com) breadapp will fail to work.

Comma vs dot in the 'amount' field in QR codes

We noticed that BreadWallet on iOS with Brazilian Portuguese
as its language fails to correctly parse the "amount" field
in QR codes, resulting in 0 values and forcing the users to
type in the amount manually. If we change the decimal point
to a comma (as it is written in Portuguese), it works correctly.
We believe you should bypass localization to avoid this bug.

Display of historical transactions wrong

First, the major issue is that historical transactions do not show the amount in bits or BTC. Instead, they show in whatever currency is selected in preferences. Second, the historical amount may include a string such as "Exchange rate when received:" then list an exchange rate. However, the rate listed is not the rate at the time of the transaction. For example, I have a transaction from October 2014 that lists the exchange rate of $16,808.00/btc, which is obviously way off for any time in 2014.

In any case, these errors combined make reconciliation difficult. It seems one must get transaction addresses and look at a blockchain browser to figure out the details. I'm not sure when this broke, but it didn't used to be this way.

Comma instead of dot in address box.

If the Local of the phone is in a country that uses the comma instead of the dot as decimal separator (like Sweden for example), the keypad that appears in Settings->Advanced->Bitcoin Nodes has the comma and the address inserted will be invalid.

By the way I think you should allow to use the name resolution for the server. My node has a different ip if I am at home or if I am abroad because the local dns resolves it differently depending on the network. This is a quite common approach.

feature request: store blockchain data/cache in normal application data store

Every time I get a new phone, I have to resync breadwallet. I get a new phone several times per year. It would be really nice if I could have the option to backup my key (if the iOS backup is encrypted, like health data and Google Authenticator data) and also the downloaded blockchain data, so that way when I restore onto a new device, it doesn't take hours to sync and receive my first payment.

Can I haz SegWit Plz?

I am a big fan of Bread Wallet and I really can't thank you guys enough for all the hard work you guys are doing. Love being able to just scan a QR code and press send.

I would really, really, really, like to be able to use SegWit to avoid paying high fees and to help the network add more capacity.

Private Key

First of all thank you for your great job! The UI and UX are really great!

I understand you want to keep the app as simple as possible, but it would be great to allow advanced users to import / export their private keys.

I would update the fees and I can't with this wallet. So either you allow the users to update them or allow them to use another wallet to configure the fees if needed.

Best

Could not build Objective-C module 'BRCore'

I would make my own app with xcode 9.
But i cannot "Make Project", i become this: error: "Could not build Objective-C module 'BRCore'"
Is there someone who knows where this error comes from?

Can't erase wallet without Paper Key

I created a wallet recently just to try some things and see how it works. There are no funds. I don't have the paper key anymore. I just want to delete all data and start over but Bread doesn't allow me to continue.

What I find very surprising is that deleting Bread doesn't make any difference. I assumed deleting an app will delete all its data and since iOS 11 not even iCloud keychain items will persist. I didn't look into how Bread persists data but from a user standpoint it's just very frustrating.
I understand that you want to strike a balance between ease of use and security, but right now I just feel extremely patronized by this rigid behavior that doesn't allow me to proceed.

Is there a solution to this?

Could Not Create Transaction. Nonce too low.

Im having a problem sending Ethereum and any ERC20 token to other wallet or exchanges. I've tried any amount but still the same error. all my transactions have been completed/confirmed no pending. Im using version 2.3 (278) on ios iphone 7 plus.

Mnemonic displayed as invalid

I have breadwallet on one iphone and try to restore the same wallet on another iphone (active/active availability ;-). When entering the 12 word mnemonic on the second (identical) breadwallet app, it shows that it is invalid. However it is valid and if I import it in electrum using BIP39, it works out fine.
Any idea what could be wrong here?

UI: Option to hide BUY button

I guess you guys get commission out of users who buy Bitcoin with credit card but would be nice to be able to hide that button.

Having only SEND/RECEIVE makes the UI cleaner.

MISSING BTC

Hello, i were using multibit hd and Breadwallet together. I used both of them with 1 wallet opened on both. Suddenly my pc broke and i tried to restore my wallet on new pc. When i restored one btc address with money on it was missing. i tried to generate private addresses from BIP39 mnemonic but i couldnt find that recieving addres in the list of 50000 address. Money is still unspent. Help me to get it back i know wallet words and everything. If someone helps me i will gift him/her a bunch of a beer on btc address :)
I reinstalled mac os everything is deleted. I know what was the wallet words 100% but there is not that addres everywhere i try. In electrum bread or etc.
When i restore wallet every other transactions are visible but the address is missing only that address.. Multibit had bugs that moment and said wrong password and etc..
If someone helps bounty will be 1000 euros.

Request: warning before spending unconfirmed outputs

I have a chain of six transactions waiting for confirmation now to six to different vendors / merchants / recipients that have been waiting for days. Bread spends unconfirmed change outputs without any indication that these additional transactions are being held up by one low-fee mistake I made a week ago. I don't know if I even have any confirmed outputs in the wallet, perhaps there is an issue with coin selection? I know you are trying to keep the wallet super simple but Bitcoin is not simple any more. Perhaps an option to view "confirmed balance" when making new transactions could be enabled

Unable to build wallet

I did all the changes required to build and test the wallet from source.But seems to not compile due to some unknown value of type errors.What can i do to build the wallet successfully?

screen shot 2018-05-18 at 6 50 38 pm

iPhone X optimization

Breadwallet already supports iPhone X, but there are a bunch of layout issues, too small images and the tight coupling of Touch ID == biometrics auth.

OT: Looking for a collaborator

Hello -

I just published INDX01 on the iOS App Store. I now would like to integrate a wallet. Hence I am on here looking at open source frameworks and came upon Bread.

Any "experienced" bread integrators out there?

ping me

Can't sync Bitcoin

I keep trying to get up to date with the blockchain but I'm stuck on Oct. 6th, 2013 forever. I'm not sure what else to try.

(Sum) when recived isn’t converted to the correct currency

If after receiving a transfer you change the currency the “when received” isn’t converted.
For example, if I receive 88.34 ILS(around 25USD) in bitcoin and I change the currency to USD it will display that it used to be 88.34 USD and not ~25 USD.

Security questions I would like to understand

  1. Does using the phone cloud storage backup can bring any security bridge ? maybe the backup store the 12 seed words on apple cloud ...
  2. What is consider to be safer ? using the 6 digit lock or fingerprint .

No trusted node fucntion for BCH?

Advanced menu, nodes, manual setting: is this still just for BTC? There's no indication if the manual node should be for BTC or BCH or both or what.

Please consider using this repository for active development

I'd like you to reconsider your stance on using this repository as a primary target for active development.

In voisine/breadwallet-ios#98, @voisine said:

I like to point out that closed source wallets require the same level of trust in the provider as hosted wallets.

In #17, @samuraisam mentioned:

We only push to this repo on releases now, but would be happy to receive any pull requests!

There are a few issues:

  1. A lot of users are running your beta release and have no way to verify what they're running.

  2. It appears that you haven't updated this repository; the latest commit, 47c17e4, is from October 3rd but the most recent App Store release was November 20th.

I understand that it makes sense to work on some features in private but I really hope you'll consider using this repository as the target for most changes.

Why do I care? A key reason for why I picked Bread was transparency. From a trust perspective, it's much easier to follow along with incremental changes than every few months when most files in the project have changed. Another argument is being able to contribute pull requests; that's difficult if the source trees diverged significantly.

Only one address listed when receiving at multiple addresses

I recently sent a multi-output, multi-address transaction to Bread. In the interface there is only one "received at" address listed. This is an advanced nitpick I know but the Transaction Details in this case are a little inaccurate for an experienced Bitcoin user.

ps My rationale for sending to Bread this way is a result of #28

Since I know my entire wallet can be frozen if I only have one single UTXO and I spend it with a low fee, I decided to fund Bread with multiple outputs to multiple addresses so I don't brick my entire wallet waiting for one tx that will never confirm.

error: "Please select num implementation"

I would make my own app with xcode 9.
But i cannot "Make Project", i become this: error: "Please select num implementation"
Is there someone who knows where this error comes from?
2018-07-02 11 50 25

Custom fees, please

I get it. Custom fees aren't "friendly". Have a toggle for power users then. Have additional option for high priority transactions. Fee prediction algorithms are never perfect and lead to seriously frustrating situations.

Immediate crash on iPhone X + iOS 11.3.1

Works fine (and looks great!) on iPhone 6 with same OS. Upgraded phones today -- boom -- immediate crash upon launch. Restarting phone doesn't help. Any ideas?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.