breadlesscode / neos-simple-editor-extend Goto Github PK

Object.keys(buttonConfig) in manifest.js will not work when no style is defined as buttonConfig is not an iterable.

This shouldn't normally be an issue, but after installing the package you have to define your config or Neos will not work anymore.

This line https://github.com/breadlesscode/neos-simple-editor-extend/blob/master/Resources/Private/UiPlugin/src/manifest.js#L9

might be an issue if your neos is operating on a relative path like https://site.com/somePath.
The api url will result in https://site.com/breadlesscode/editor-config instead of https://site.com/somePath/breadlesscode/editor-config

The are use cases where you should be able to select from a list of styles for the same piece of text.
The current mechanism would generate a button for each style and they might stack, when an editor presses several buttons.

With a dropdown it could be enforced that one of a set of styles is only selected. This would also use less space in cases where more than 3 styles are available.

I just started working on a time critical custom implementation and would try to create a PR for this package when I'm done.