braveclojure / cftbat-code Goto Github PK

You mention in chapter 5 to download the code from github and then run 'lein run' in the pegthing directory. I don't see a pegthing directory. And I tried to run 'lein run' in the chap 5 directory and got an error. Please advise.

In Chapter 8, when explaining unquote splicing you change the macro arguments from 2 arguments to using a map and keywords. The example that follows is then incorrect (and doesn't run in my REPL)
https://github.com/braveclojure/cftbat-code/blob/master/08/code.clj#L231

This line should read instead
(code-critic {:good (1 + 1) :bad (+ 1 1)})

As far as I understand the argument change is unrelated to the unquote splicing and just makes things more confusing. Please correct me if I'm wrong :)

Thanks for the great book. I'm enjoying it a lot

On windows the supplied url function doesn't provide the proper url since windows returns with \ instead of other systems and browsers that need /. Its a simple fix however that I at least wanted to mention here.

(defn url
  [filename]
  (s/replace (str "file:///"
              (System/getProperty "user.dir")
              "/"
              filename)
             #"\\" "/"))

I get a messily ordered vector of hobbit body parts when I execute (symmetrize-body-parts asym-hobbit-body-parts) .

According to the answer shown in the book and the code , symmetrize should return a vector of body parts which has {left-part} before the matching {right-part}.

But When I execute, I get the following vector.

Note that towards the end of the vector, the matching {right-part} comes before {left-part}.

Am I doing something wrong? or is this a bug?

Thank you.

(symmetrize-body-parts asym-hobbit-body-parts)
=>
[{:name "head", :size 3}
 {:name "left-eye", :size 1}
 {:name "right-eye", :size 1}
 {:name "left-ear", :size 1}
 {:name "right-ear", :size 1}
 {:name "mouth", :size 1}
 {:name "nose", :size 1}
 {:name "neck", :size 2}
 {:name "left-shoulder", :size 3}
 {:name "right-shoulder", :size 3}
 {:name "right-upper-arm", :size 3}
 {:name "left-upper-arm", :size 3}
 {:name "chest", :size 10}
 {:name "back", :size 10}
 {:name "left-forearm", :size 3}
 {:name "right-forearm", :size 3}
 {:name "abdomen", :size 6}
 {:name "left-kidney", :size 1}
 {:name "right-kidney", :size 1}
 {:name "left-hand", :size 2}
 {:name "right-hand", :size 2}
 {:name "right-knee", :size 2}
 {:name "left-knee", :size 2}
 {:name "right-thigh", :size 4}
 {:name "left-thigh", :size 4}
 {:name "right-lower-leg", :size 3}
 {:name "left-lower-leg", :size 3}
 {:name "right-achilles", :size 1}
 {:name "left-achilles", :size 1}
 {:name "right-foot", :size 2}
 {:name "left-foot", :size 2}]

Illegal character in path at index 10: file:/// ..../the-divine-cheese-code/map.html

and here's the code :

(defn -main
  [& args]
  (let [filename "map.html"]
    (->> heists
         (xml 50 100)
         template
         (spit filename))
    (browse/browse-url (url filename))))