brave / adblock-resources

Custom resources and scriptlets used for Brave's adblocker

This repo is now obsolete, thank you to all the previous contributors in https://github.com/brave/brave-browser-snap/pulls?q=is%3Apr+is%3Aclosed.

Snap YAML has moved to https://github.com/brave/brave-core/blob/master/snapcraft.yaml

More details at brave.com/linux. For issues please visit github.com/brave/brave-browser/issues.

adblock-resources's Issues

Add `npm run verify` as a git commit hook

Just to ensure that we never wind up with bad json here, and potentially breaking the DAT, WDYT of adding npm run verify as a commit hook?

Add license information for filter lists

Storing a license field along with each of the filter list entries will allow us to easily confirm that we are allowed to ship all of the adblock lists, and will allow license information to be automatically updated in brave://adblock, preventing the two from falling out of sync with each other.

A corresponding check could be added to verify.js to ensure the field is present on all entries, and specifies a compatible license.

Verify component ids match public keys in CI

We can use this code for it. Should help to protect against something like #198 happening again.

uBlock Annoyances list useless becuase of lack of !#include

I was checking around and noticed uBlock annoyances list is pretty much useless in Brave because brave lacks of !#include and it seems uBlock list maintainers love abusing that feature, like if having a single list would change things, especially in this one, because it doesn't have anything but two !#include rules that are 'merging annoyances-cookies and annoyances-others in the annoyances list and that's it.

The file annoyances.txt only contains this, which doesn't make sense in my opinion.

! Title: uBlock₀ filters – Annoyances
! Description: |
!   Filters optimized for uBlock Origin, to be used with Fanboy's
!   and/or Adguard's "Annoyances" list(s)
! Expires: 7 days
! Last modified: %timestamp%
! License: https://github.com/uBlockOrigin/uAssets/blob/master/LICENSE
! Homepage: https://github.com/uBlockOrigin/uAssets
! Forums: https://github.com/uBlockOrigin/uAssets/issues

!#include annoyances-cookies.txt
!#include annoyances-others.txt

That's it, so I guess, Brave has to update it the regional.json to make it useful again, but I hope !#include will be implemented eventually to avoid this ridiculous way of making lists.

Need help

https://community.brave.com/t/question-about-brave-adblock/506027

Can you able to ans these questions? Or able to provide informations about this @antonok-edm

Anyone who can please reply to those questions

PersianBlocker list for Persian websites

PersianBlocker is a rewrite of Adblock-Iran (with filters added from two other Persian lists).

Adblock-Iran is currently present in Brave but it has been unmaintained for 6 months, so uBlock Origin and AdGuard have replaced it with PersianBlocker:
gorhill/uBlock@33b839f
AdguardTeam/FiltersRegistry@101680b

Details:

        "url": "https://raw.githubusercontent.com/MasterKia/PersianBlocker/main/PersianBlocker.txt",
        "title": "IRN: PersianBlocker",
        "format": "Standard",
        "langs": ["fa"],
        "support_url": "https://github.com/MasterKia/PersianBlocker",
        "desc": "Finally, an optimal and extensive list for blocking ads and trackers on Persian language sites!"

Though I think the "desc" should be in the corresponding language, not in English:
سرانجام، یک لیست بهینه و گسترده برای مسدودسازی تبلیغ ها و ردیاب ها در سایت های پارسی زبان!

Pop up ads

Add my Nordic list

My list is now possibly the only regional list that is included in uBO but not in Brave, not to mention it's just ~2 weeks away from being included in ABP as well, so I'd say it's about time to add it to Brave. Details:

    "url": "https://raw.githubusercontent.com/DandelionSprout/adfilt/master/NorwegianExperimentalList%20alternate%20versions/NordicFiltersBrave.txt",
    "title": "Dandelion Sprout's Nordic Filters",
    "format": "Standard",
    "langs": ["nb", "nn", "no", "da", "is"],
    "support_url": "https://github.com/DandelionSprout/adfilt/issues",
    "desc": "Removes advertisements from Norwegian, Danish and Icelandic websites"

Alternately the URL can be replaced with "https://raw.githubusercontent.com/DandelionSprout/adfilt/master/NorwegianList.txt",, depending on which one you feel has the more suitable syntax both currently and in the near future.

Question about generic cosmetics filters

Idk but fanboy annoyance ubo has more rules than easylist annoyance(fanboy annoyance)ubo

`

This is the difference between them
@ryanbr

Add new regional list

Hi, please add new regional Filterlist for Indonesia & Malaysia users. This filter (AdblockID) more powerful than ABPIndo.. Many of Indonesian people don't know how to subscribe the filter manually. I hope brave will include it as default regional filter https://github.com/realodix/AdBlockID

Brave fails to prevent click tracking on DuckDuckGo

Default lists for Brave Browser have an entry for ‘uBlock Origin filters – Privacy’, which has a rule handling click tracking on DuckDuckGo:

html.duckduckgo.com,lite.duckduckgo.com##+js(href-sanitizer, a[href^="//duckduckgo.com/l/?uddg="], ?uddg)

Unfortunately the rule doesn't apply. (I've no idea how many thousands of default rules don't apply either. Probably all of them.)

Steps to reproduce:

1. Search anything on DuckDuckGo, e.g. by typing :d Brave in omnibox.
2. Block scripts.
3. All links on the page are now of the form https://duckduckgo.com/l/?uddg=....

Separate option for Ads and Trackers.

Need separate option for Ads and Trackers. Because, for the sake of blocking all ads if I select Trackers & ads blocking to Aggressive on Shields the problem of website breaking arise and in order to prevent website breakage if I select Trackers & ads blocking to Standard then some ads not getting blocked. So, My humble request kindly introduce two separate options so that one can select Ads blocking to Aggressive and Trackers blocking to Standard.

@antonok-edm
@ryanbr

Switch from YousList to List-KR

Can you replace the local list?
A list of Korean regions currently in the Brave browser.
youslist is not actively maintained and
List-KR The list is being more actively maintained
List-KR I hope it will be changed to a list.
ublock origin has also been replaced from youslist to List-KR.

List-KR:https://github.com/List-KR/List-KR

Use component IDs instead of UUIDs for regional lists

Component IDs are already unique identifiers (secured through secure randomness + cryptography by being generated from a per-component private key). Having an additional UUID field is a bit redundant, and we could reduce overall complexity by using component IDs instead.

Note that this change will require changes in brave-core to migrate UUIDs in local preference storage, so that users' enabled filter lists are not reset: see brave/brave-browser#27708.

Cd

Tasks

Beta Give feedback

1. Update adguard url tracking protection list public key #198
   +0
   

uBlock Origin quick fixes list

uBO has a quick fixes list, Brave should do the same.

https://github.com/uBlockOrigin/uAssets/blob/master/filters/quick-fixes.txt

Filters for sites that constantly/daily change their CSS names to avoid blockers (as you can see in the commit history) are only applied in the quick fixes list and not the main list.

Replace Fanboy's Korean with List KR

Fanboy's Korean no longer updated for several years. Please consider to delete/replace it with List KR

cc: @antonok-edm @ryanbr

Add new uBlock filters-2024

new uBO filter-2024 already out now.Will this latest filter also be added to Brave?

cc: @ryanbr @antonok-edm

Adblocker bug

Using brave browser 1.59.117 Android
Using hagezi DNS Blocklist in custom filters

>

It has a ad server domain pinkleo.pro

>

Using that Blocklist in custom filterlist Blocks that domain blocks ad but not that cross/close button located above search button

>

But when blocking that domain by manually writing it in custom rules box

>

Blocks that cross or close button whatever you say

>

On this site it may be a little thing but maybe on other site it is big idk I noticed it and reported and I also don't know if this is a browser based problem or rules problem so I reported here

@antonok-edm
@ryanbr
Please fix this if this a issue or just let me know why it's happening

Thanks

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update actions/setup-node digest to 1e60f62
• Update tj-actions/changed-files action to v45

Detected dependencies

github-actions

.github/workflows/ci.yml

• actions/checkout v4@692973e3d937129bcbf40652eb9f2f61becf3332
• actions/checkout v4@692973e3d937129bcbf40652eb9f2f61becf3332
• actions/setup-node v4@60edb5dd545a775178f52524783378180af0d1f8
• tj-actions/changed-files v41@cbda684547adc8c052d50711417fa61b428a9f88
• actions/checkout v4@692973e3d937129bcbf40652eb9f2f61becf3332
• actions/setup-node v4@60edb5dd545a775178f52524783378180af0d1f8
• tj-actions/changed-files v41@cbda684547adc8c052d50711417fa61b428a9f88

npm

package.json

• adblock-rs 0.8.12

---

• Check this box to trigger a request for Renovate to run again on this repository