brarcher / gift-card-guard Goto Github PK

If an image is captured and the screen rotated the image is lost. Instead, the image should be saved.

You tagged version 0.1, but app/build.gradle says its 1.0. Could you release a version 0.2 with a matching tag? Also don't forget to increase the versioncode (from 1 to 2 or above).

I'd like to design an icon that follows material design guidelines.

@brarcher i am wondering whether this is https://github.com/brarcher/gift-card-guard#note-from-developer still relevant ;)

Good morning @brarcher, first of all: Thanks for developing this great app and especially for putting it on F-Droid! I am a very visual person and would like to see these small improvements to your README:

• Rename gift-card-guard to Gift Card Guard so that it corresponds to the published app name.
• Link an F-Droid button just like I added via pull request on another project called Binaural Beats.
• Seems like you copied the README of your other project, otherwise this sentence would be erased:

If there is any interest in improving this open source baby monitor, kindly submit a pull request with proposed changed.

If in landscape, not all fields may fit on the screen. As the screen will not scroll through the fields, one must rotate the screen to access the save button.

Is it possible to set currency by hand? By now I saw that it is a hardcoded string.
I'm Italian and I use euros, not US dollars ;)

I'm a PhD student interested in finding security vulnerabilities in open source projects.

We found a total of 4 warnings (indicating potential vulnerabilities) when running the CogniCrypt static analyzer (*) on gift-card-guard (or its library dependencies). We documented these issues in private gists for the sake of confidentiality (non-disclosure).

Can you please let us know whether we can share these gists with you? We are eager to evaluate the perception of developers (e.g. severity of these warnings) and improve gift-card-guard's security, and the quality of the reports of static analysis tools.

(*) https://github.com/CROSSINGTUD/CryptoAnalysis

Is it possible to extend support not only to gift card but also to general cards (i.e. supermarket cards)?

• They don't need values as they don't store money but they would need optionally values for points
• Instead of take picture of the card, the app should show the generated barcode with max backlight:
  • Here is a guide on how to manage bar codes in Java
  • I tested some cards with my bar code and I found out that the bar code format is UPC_A
  • It should show the card ID too

Open About in Menu, WebView dialog shows. But it disppears after device rotation.

Screenshot before rotation

Screenshot after rotation