Coder Social home page Coder Social logo

brandid / hello-pro Goto Github PK

View Code? Open in Web Editor NEW
2.0 3.0 0.0 8.72 MB

Hello! Pro - A Gutenberg-Optimized Child theme for the Genesis WordPress framework

Home Page: https://demo.hellopro.personalbranding.thebrandid.com

PHP 44.18% JavaScript 6.65% CSS 49.16%
theme wordpress-theme personal-branding gutenberg-compatible gutenberg

hello-pro's People

Contributors

alexmustin avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar

hello-pro's Issues

Header Navigation Styles - Drop-down menus, Mobile menu

Describe the bug
Header navigation menu needs the default styles updated:

DESKTOP

  • Need indicator icon for drop-down menus

MOBILE

  • Mobile menu button is invisible on hover
  • Need indicator icon for drop-down menus

To Reproduce
Steps to reproduce the behavior:

  1. Add a sub-menu item to the main header right menu
  2. Go to any page
  3. Notice the drop-down menus have no icon to indicate there is a sub-menu
  4. Make the browser window narrow so it goes into Mobile view
  5. Hover over the Mobile Menu button, notice it becomes transparent on hover
  6. Notice the drop-down menus have no icon to indicate there is a sub-menu

Expected behavior
Issues above should be fixed

Screenshots
HelloPro3--desktop-dropdown-menu
HelloPro3--mobile-menu-button
HelloPro3--mobile-menu-dropdown-open

Desktop (please complete the following information):
(All)

Smartphone (please complete the following information):
(All)

Additional context
N/A

Block Template Site Inner Spacing

When using the block template there is no spacing between the header and the site inner. You have to add a spacer is there a better way to do this? Do we have the spacing information in the docs for users?

Screen Shot 2019-09-23 at 8 19 26 PM

Reference to localhost in homepage block-editor code

Describe the bug
When I install the theme, the cover block on the homepage shows as broken. I'm not sure if this is the reason or not, but I noticed that the image was pulling from "localhost" which is not what I call my local development server. See here:

<div class="wp-block-cover alignfull has-background-dim-30 has-black-background-color has-background-dim statement" style="background-image:url(http://localhost/hellopro3-dev/wp-content/themes/hello-pro-3/config/import/images/home-statement-default.jpg)"><div class="wp-block-cover__inner-container"><!-- wp:paragraph {"align":"left","placeholder":"Write title…","fontSize":"huge"} -->

That image was not working and doesn't seem to have been imported during the onboarding process.

To Reproduce

  1. Install the theme.
  2. View the homepage in wp-admin
  3. Scroll down to the cover block.
  4. Notice it looks like this:

Screen Shot 2020-03-05 at 12 09 11 PM

Expected behavior
I expect the block to have no errors.

Desktop (please complete the following information):

  • OS: OSX
  • Browser: Chrome
  • Version: 80.0.3987.122 (Official Build) (64-bit)

Blog page default is a bit confusing

Describe the bug
When I go to edit my blog page, I see a paragraph block that says This is where the magic happens! Include a brief paragraph at the top of your blog so readers know what topics or themes they can expect to read about — and look forward to! ok.

On the frontend, it is loading the archive-portfolio.php template, and the contents of that block are not used. Could that paragraph be removed, or help make it clear that the page's content does not come from Gutenberg?

Screen Shot 2020-03-06 at 3 24 02 PM

Header JS issues with WP 5.5 update

Describe the bug
New issues with the header introduced with the latest WP 5.5 release:

  • Sticky Header not behaving properly on scroll.
  • Mobile Nav Menu Button disappears when screen is 1023px or narrower.

To Reproduce
Steps to reproduce the behavior:

  1. Update WP to 5.5
  2. Ensure 'sticky header' option is enabled in Customizer
  3. Scroll down on a page, see the Sticky Header issue
  4. Make the browser window very narrow, see the Mobile Nav Menu Button issue

Expected behavior
Sticky Header should behave as expected.
Mobile Nav Menu Button should appear when screen is 1023px or narrower.

Screenshots
N/A

Desktop (please complete the following information):
(All)

Smartphone (please complete the following information):
(All)

Additional context
Same issue experienced with Course Maker Pro:
brandid/course-maker-pro#19

Genesis Page Layout setting is disabled/missing in Page Editor

There is an issue with not being able to choose the Genesis Page Layout setting on each page when using the Page Editor.

  • If the user selects the "Content/Sidebar" layout under Genesis settings in the Customizer, the Sidebar will display on pages by default.

  • If the user selects the "Blocks" page template on a page, it will force the page to be full-width, regardless of the Customizer layout setting.

This is not obvious to users.

Current behavior:
The Genesis Layout Settings panel is missing from the Page Editor. Because of this, the user cannot deviate from the page layout set in the Customizer.

Expected behavior:
The user should be able to use the Genesis Layout Settings on each page.

Screenshot of the missing Genesis Layout Settings panel:
https://p47.f4.n0.cdn.getcloudapp.com/items/YEu874dN/Image+2019-09-23+at+7.14.50+PM.png?v=bc3093f3455aee61fa7bf8359b6af9ce

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.