bradunov / shkola Goto Github PK

We get "The table specified already exists" in every access which messes up the error log. Fix this.

Currently, all requests are GET, which is problematic for e.g. bookmarking as some state is stored in them. It is cleaner to convert all GETs to POSTs. However, this requires some redesign as one needs to add a hidden form for that.

Questions 9, 11, 13a have input under the tables. Make the input show next to the table

Currently, after session cookie expires (user closes the browser), the user needs to login again.
We should add persistent cookie to keep user logged in for a longer period.
The value of the cookie must be randomly generated and corresponding value stored in the user table.

Currently www.tatamata.org points to the web site, but not tatamata.org. This cannot be done with Azure Functions but can be done with a VM. Once a VM is up, set it up using these instructions: https://docs.microsoft.com/en-us/answers/questions/34737/how-to-point-your-dns-zone-apex-root-naked-domain.html

At some point we broke logout feature. Check if it works now

Logout mechanism should be implemented:

• Session / user cookie should be deleted.
• session record should be marked as invalid.

Currently, user sessions are not being cached in memory and are always pulled from a table. Implement local session state caching and also store precalculated scores there to speed up new question generation.

All 3 should be stored in the user table (and/or session ?)
accepted_language should be stored as is.

Every time there is an exception, log it on Azure

Make Enter submit a form when working on a question. However, this doesn't seem very easy to do by default.

Currently the paritition key is constant "USER" and may not be optimal for performance. Modify.

Design URL key is no longer used on the site. Remove it.

There should be an absolute time limit (for example 24h) for the session cookie.

The code should measure time it takes to generate the page from the enry point to exit point of azure.

• The values should be grouped by "key" (probably op parameter).
• The values should be periodically stored in the azure table.

Currently, Reload doesn't work in Azure function. Fix it.

Currently page is constructed by appending strings to a string value which is very inneficient.
We should use some more efficient mechanism.
Also, it probably would be better to have page body object in the context and not passed as a return value from functions.

The circles are not centered while the other figures are centered.

When a list of all questions applicable to a test is too small, less than a number of questions to be asked in the text, the site fails. One example is:
https://www.tatamata.org/main?op=test&q_id=&l_id=&year=drugi&theme=brojevi&subtheme=brojevni%20izrazi&period=jesen&difficulty=2&language=rs&design=dev
Fix this.

Currently session state stores the entire page_param object, which contains parts of the page params that are not part of the state, but of each request (e.g. root, op). This should be refactored so that we store in the session only parts that are necessary for the state. We should refactor page_params into page_params.session and page_params.request.

Whenever a question in rendered in JS, it has both check and solution. Add automatic test of solution in check and submit an error to the table if they don't match, to catch potential errors caused by random values at users' browsers.

In order to avoid table query for each request, session caching should be implemented.
A mechanism (probably cookie based) is needed to guarantee consistency in case session requests are coming to different hosts.

Skipping a question generates the following two requests (example):

Line 38:       MAIN ARGS ASYNC: {'q_id': 'numbers/q00028', 'l_id': '1_brojevi.rs', 'language': 'rs', 'test_id': 1598174968603, 'test_order': 1, 'start': '1598174968', 'now': '1598174975', 'attempt': '1', 'shown_solutions': False, 'detailed': {'q_res0': 'false', 'q_res1': 'false', 'q_res2': 'false', 'q_res3': 'false', 'q_res4': 'false'}, 'response_type': 'SKIP', 'op': 'register', 'root': 'main'}
Line 92:       MAIN ARGS ASYNC: {'q_id': 'numbers/q00028', 'l_id': '1_brojevi.rs', 'language': 'rs', 'test_id': 1598174968603, 'test_order': 1, 'start': '1598174968', 'now': '1598174975', 'attempt': '0', 'shown_solutions': False, 'detailed': {'q_res0': 'false', 'q_res1': 'false', 'q_res2': 'false', 'q_res3': 'false', 'q_res4': 'false'}, 'response_type': 'SUBMIT', 'op': 'register', 'root': 'main'}

There should only be a SKIP one, not a SUBMIT one, as both have enough info.

• Remove irrelevant Azure Functions log messages
• Print module name and other relevant info
• Perhaps use Opencensus to get simpler and better searchable logs in LogAnalytics
• Add extra log analytics JSON fields for better filtering

User and session database objects are currently created for every request. They should be created only once.

Azurlite works well as a local backend so no need to keep SQLite backend up to date. Remove it from the current calls and make sure that edit option works without it.

We currently have an exception handler for uncaught errors but it only displays an error message in dev mode. We need to log it in a table for wider deployments.