bountygiver / detailedsoldierlistwotc Goto Github PK

Some mods make use of the new soldier status hooks to add new statuses, modify how the time is displayed, and so on. These mods (for example Long War of the Chosen and Covert Infiltration) don't work with Detailed Soldier List right now because it replaces the corresponding base game function (GetPersonnelStatusSeparate()) with its own copy of the original code.

I plan to submit a pull request for this.

The Community Highlander allows mods to override the displayed ranks of soldiers. For example, the LW2 Leaders mod (or whatever it's called) may want to display the officer ranks rather than the underlying soldier ranks. At the moment, Detailed Soldier Lists just uses the basic vanilla implementation.

The XP information that's shown doesn't correspond to actual soldier XP and the XP required for the next rank as far as I can tell, at least for any mod that overrides the base game's XP values. The code should really be delegating to XComGameState_Unit.GetTotalNumKills(), particularly as that has a hook in the highlander version that mods make use of.

I'll submit a pull request after some testing.