botreeconsultingteam / github_commits Goto Github PK

Hi @ParthBarot-BoTreeConsulting and thanks for this great plugin!

We would like to use this plugin and to enhance it, but there are no license actually on the plugin. Could it be possible for you to add a License file on the repository so everybody can use your work accordingly to your will.

It seems like actually you're open with the fact that people can use it, enhance it and share new enhancement, so maybe a MIT License could be a good choice.

But I don't know your opinion about commercial usage and resell of your work, so GPL/AGPL could be a good option also if you want to force people re-share it on same license.

While merging branches in git, Github sends out the same commit notification again on push. As of now this is creating another comment for the same commit, just the branch name is different.

Steps to reproduce

1. Create one branch, push small change into it with the message mentioned as per wiki - including the Redmine issue number.
2. github will send a push notification to the webhook URL, and it should create a comment in the redmine issue.
3. Now merge this branch into another branch on git, push again.
4. Step 3 will be executed again, branch name would be different. And this will create another comment on the issue for same commit.

Approach

We have to keep track of the commit id/hash, so that when the same comment comes again from github we can restrict it.

Findings

1. Journal is comment, it has has_many :journal_details, but storing this hash in this table would require a query which can check if the hash exists in this table, if not then only enter a new comment for the hash.
2. We need to track the hash at issue level, so before inserting a new comment (journal) we can verify if that issue has already received this comment before?

is it possible line number inserted modify or how many lines code done by users or developers ?

I can't get this plugin to work, I only get a 404 error.
The plugin is placed in redmine/plugins/github_commits with the same permissions as the rest of my Redmine files.
The plugin is active and up to date according to the plugins list within Redmine.
I've run bundle install and bundle exec rake redmine:plugins:migrate RAILS_ENV=production after placing it in the plugins folder.

Redmine version: 3.3.2
Plugin version: 0.0.2

Have I missed some important step in the installation process or am I just stupid in some other way? I really don't see what I've could have missed.

Here's the log output after posting to the webhook from GitHub:

Started POST "/github_commits/create_comment" for 192.30.252.40 at 2017-03-27 11:13:07 +0200

ActionController::RoutingError (No route matches [POST] "/github_commits/create_comment"):
  actionpack (4.2.7.1) lib/action_dispatch/middleware/debug_exceptions.rb:21:in `call'
  actionpack (4.2.7.1) lib/action_dispatch/middleware/show_exceptions.rb:30:in `call'
  railties (4.2.7.1) lib/rails/rack/logger.rb:38:in `call_app'
  railties (4.2.7.1) lib/rails/rack/logger.rb:20:in `block in call'
  activesupport (4.2.7.1) lib/active_support/tagged_logging.rb:68:in `block in tagged'
  activesupport (4.2.7.1) lib/active_support/tagged_logging.rb:26:in `tagged'
  activesupport (4.2.7.1) lib/active_support/tagged_logging.rb:68:in `tagged'
  railties (4.2.7.1) lib/rails/rack/logger.rb:20:in `call'
  actionpack (4.2.7.1) lib/action_dispatch/middleware/request_id.rb:21:in `call'
  rack (1.6.5) lib/rack/methodoverride.rb:22:in `call'
  rack (1.6.5) lib/rack/runtime.rb:18:in `call'
  activesupport (4.2.7.1) lib/active_support/cache/strategy/local_cache_middleware.rb:28:in `call'
  actionpack (4.2.7.1) lib/action_dispatch/middleware/static.rb:120:in `call'
  rack (1.6.5) lib/rack/content_length.rb:15:in `call'
  rack (1.6.5) lib/rack/sendfile.rb:113:in `call'
  railties (4.2.7.1) lib/rails/engine.rb:518:in `call'
  railties (4.2.7.1) lib/rails/application.rb:165:in `call'
  railties (4.2.7.1) lib/rails/railtie.rb:194:in `public_send'
  railties (4.2.7.1) lib/rails/railtie.rb:194:in `method_missing'
  /usr/lib/ruby/vendor_ruby/phusion_passenger/rack/thread_handler_extension.rb:97:in `process_request'
  /usr/lib/ruby/vendor_ruby/phusion_passenger/request_handler/thread_handler.rb:160:in `accept_and_process_next_request'
  /usr/lib/ruby/vendor_ruby/phusion_passenger/request_handler/thread_handler.rb:113:in `main_loop'
  /usr/lib/ruby/vendor_ruby/phusion_passenger/request_handler.rb:416:in `block (3 levels) in start_threads'
  /usr/lib/ruby/vendor_ruby/phusion_passenger/utils.rb:113:in `block in create_thread_and_abort_on_exception'