Comments (5)
Hi @colinbjohnson thanks for reaching out. The latest EC2 waiter models are in this file. Can you specify the differences you're seeing? Looking at these two files, they seem to follow the same basic structure (apart from the order of keys, and the ssm-incidents
file containing a description
):
![image](https://private-user-images.githubusercontent.com/87778557/324124272-fb8e6d36-f380-418e-a442-f8a84f9cf44a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg4MjYxNDAsIm5iZiI6MTcxODgyNTg0MCwicGF0aCI6Ii84Nzc3ODU1Ny8zMjQxMjQyNzItZmI4ZTZkMzYtZjM4MC00MThlLWE0NDItZjhhODRmOWNmNDRhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE5VDE5MzcyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg2ZmE4ZmRjZTk0ZjIyNmUzNzZiOGI1NGUwOThkMzBiZTJmOGEyOTIwNzk2NmU0MmJlOTNhYTQyZGEwNDllZmEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.EEwHbZivRLUkKvKtbxrPdi_9lElBPYNaF_vXwbg0LxU)
Have you observed any inconsistencies in functionality between the waiters, or can you provide more context on your use case?
Waiters are also now maintained by service teams, so if any bugs or feature requests involving waiters would likely need to get forwarded to the corresponding service team. But minor formatting changes may not get prioritized unless there is some use case in which you are blocked.
from botocore.
Two things to look at (which a linter might catch <- I just don't know if there are linters available that can catch these things):
- The acceptor configuration in most waiters files utilize list items that end on one line and start on the next line:
Typical acceptor block:
},
{
as opposed to a single-line format used in botocore/botocore/data/ssm-incidents/2018-05-10 /waiters-2.json
:
}, {
- The number of spaces after a "key" in most waiters files is typically 0 spaces whereas in
botocore/botocore/data/ssm-incidents/2018-05-10 /waiters-2.json
it is 1 space.
Typical waiters file:
"operation": "GetReplicaSet"
Versus botocore/botocore/data/ssm-incidents/2018-05-10 /waiters-2.json
:
"operation" : "GetReplicaSet"
from botocore.
I completely understand how this wouldn't be a priority but I'd also be open to submitting a (separate) PR that includes JSON linting. My own hope would be that something (admittedly small) like JSON linting would help establish the importance of consistency across a codebase and across AWS teams.
from botocore.
Thanks for following up and expanding on the issue. I brought this up with the team for discussion and the takeaway was that this would need to be addressed by the service team. The reason is because waiter models are shared across SDKs, and any changes we would make to the models would be overridden by changes made by the service teams.
That being said, I think we should strive for consistency among these models. If you have a support plan then I recommend reaching out through AWS Support requesting that the SSM team update the format of their waiter model. Alternatively, you can create an issue in our cross-SDK repository and someone can reach out on your behalf.
from botocore.
This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
from botocore.
Related Issues (20)
- botocore still ignore "HTTP/1.1 100" HOT 2
- WAFV2 PutLoggingConfiguration raising AccessDeniedException without naming required permissions HOT 2
- Occasional segfaults when using Client from multiple threads HOT 6
- start_live_tail raising an error when executed in a Lambda - Header not supported – X-Amzn-Trace-Id HOT 5
- sqs create_queue does not return `QueueUrl` since v1.34.90 HOT 5
- `boto3.client('wellarchitected').get_profile_template()` raises RuntimeError HOT 4
- Performance issue due to SSLContext being recreated over and over HOT 1
- OSError: [Errno 24] Too many open files causes CredentialRetrievalError HOT 3
- Client.head_object raises ClientError instead of NoSuchKey HOT 2
- Add support for fast fail when token bucket empty
- The request signature we calculated does not match the signature you provided: Check your AWS Secret Access Key and signing method HOT 2
- RecursionError through botocore/endpoint_provider.py:572 HOT 3
- Support environment variable for S3 addressing_style config HOT 3
- Add GlobalSign Root R6 to cacert.pem HOT 2
- Waiter documentation about error behavior is incorrect HOT 1
- Retry on `IllegalLocationConstraintException` HOT 1
- Stubber.add_response for query method validate against an invalid schema HOT 3
- datetime.datetime.utcnow() is deprecated as of Python 3.12 HOT 2
- Memory leak tests use substantially more memory on Python 3.13 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from botocore.