Support environment variable for S3 addressing_style config about botocore

[github-actions]

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

[tim-finnigan]

Thanks for the feature request, but I think we need more information here. When I run the following:

import boto3
client = boto3.client('s3')
boto3.set_stream_logger('')
client.list_objects(Bucket='us-east-1-bucket')

Then the debug logs show this endpoint, which is the virtual style and contains the region:

Endpoint provider result: https://us-east-1-bucket.s3.us-east-1.amazonaws.com

And if I run this:

import boto3
from botocore.config import Config
boto3.set_stream_logger('')
client_config = Config(s3={"addressing_style": "path"})
client = boto3.client('s3', config=client_config)
client.list_objects(Bucket='us-east-1-bucket')

Then the debug logs show this:

Endpoint provider result: https://s3.us-east-1.amazonaws.com/us-east-1-bucket

So the default behavior is consistent with S3 virtual hosting format: https://bucket-name.s3.region-code.amazonaws.com/key-name

Based on that, I think it's already doing what you're looking for, right? Unless I'm missing something involving your region/version or use case. And there is a (delayed) plan for S3 to deprecate path style requests. So I don't think an environment variable would be considered here.

[skeggse]

Ah, shoot. I looked closer, and it looks like the behavior I observred was the result of using a bucket name that doesn't work as a hostname. I had assumed I was configuring something wrong.

As a side note, will bucket names with underscores stop working at some point? Obviously, we'd rather migrate, but... there are lots of priorities.