botman / studio-addons

BotMan Studio addons

BotMan Studio Addons

Addons used in combination with BotMan Studio.

Contributing

Please see CONTRIBUTING for details.

Security Vulnerabilities

If you discover a security vulnerability within BotMan, please send an e-mail to Marcel Pociot at [email protected]. All security vulnerabilities will be promptly addressed.

License

BotMan is free software distributed under the terms of the MIT license.

studio-addons's Issues

Roadmap to support Latest Laravel 5.8, 6, 7 and 8

• Add GitHub actions to tests against all currently supported Laravel versions.
• Add support for Laravel 5.8
• Add support for Laravel 6
• Add support for Laravel 7
• Add support for Laravel 8

Laravel 5.8 breaking changes

Reported at #37, #38

Laravel 5.8 changed the signature of Illuminate\Support\Composer::getProcess(). Attempting to install drives from Botman Studio now throws an error.

Error

Too few arguments to function Illuminate\Support\Composer::getProcess()
0 passed in vendor/botman/studio-addons/src/Composer.php:17
1 expected at vendor/laravel/framework/src/Illuminate/Support/Composer.php:93

Fix

Instead of passing the command as a string to setCommandLine(), this PR passes the command as an array to getProcess().

References

• laravel/framework#27610
• laravel/framework@d1b9481#diff-10f3aec8c5912d20246f5df216548880L78

Upgrade for Laravel 7

Hello,

I'm unable to use this package on a Laravel 7 project.
The commit #43 added support for it but there has been no release since that commit.

Thanks

Botman directory name

studio-addons/src/Console/Commands/BotManMakeTest.php

Line 48 in 686fba3

return $rootNamespace.'\..\tests\Botman';

It should be 'BotMan'.

It creates a new directory(Botman), instead of using the existing directory(BotMan).

Check if composer install was successful

When installing a BotMan driver using the artisan command, we need to check if an error occurs and tell the user.
Right now we're always showing a success message.

https://github.com/botman/studio-addons/blob/master/src/Console/Commands/BotManInstallDriver.php#L78

Found problems with add botman to existing projects

I used Laravel 5.7 and when I run composer require botman/stodio-addons it appear this error
`Symfony\Component\Debug\Exception\FatalErrorException : Class BotMan\Studio\Console\Commands\BotManCacheClear contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Illuminate\Console\GeneratorCommand::getStub)

at C:\mychatbot\vendor\botman\studio-addons\src\Console\Commands\BotManCacheClear.php:50
46| }
47|
48| $this->info('BotMan cache cleared!');
49| }

50| }
51|

Whoops\Exception\ErrorException : Class BotMan\Studio\Console\Commands\BotManCacheClear contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Illuminate\Console\GeneratorCommand::getStub)

at C:\mychatbot\vendor\botman\studio-addons\src\Console\Commands\BotManCacheClear.php:50
46| }
47|
48| $this->info('BotMan cache cleared!');
49| }

50| }
51|

PHP Warning: Uncaught ErrorException: Declaration of BotMan\Studio\Console\Commands\BotManCacheClear::handle(Illuminate\Filesystem\Filesystem $files) should be compatible with Illuminate\Console\GeneratorCommand::handle() in C:\mychatbot\vendor\botman\studio-addons\src\Console\Commands\BotManCacheClear.php:50
Stack trace:
#0 C:\mychatbot\vendor\composer\ClassLoader.php(444): Illuminate\Foundation\Bootstrap\HandleExceptions->handleError(2, 'Declaration of ...', 'C:\mycha...', 50, Array)
#1 C:\mychatbot\vendor\composer\ClassLoader.php(444): include()
#2 C:\mychatbot\vendor\composer\ClassLoader.php(322): Composer\Autoload\includeFile('C:\Work\Git\cha...')
#3 [internal function]: Composer\Autoload\ClassLoader->loadClass('BotMan\Studio\C...')
#4 [internal function]: spl_autoload_call('BotMan\Studio\C...')
#5 C:\mychatbot\vendor\laravel\framework\src\Illuminate\Container\Container.php(767): ReflectionClass->__construct('BotMan\Studio\C in C:\mychatbot\vendor\botman\studio-addons\src\Console\Commands\BotManCacheClear.php on line 50
PHP Fatal error: Class BotMan\Studio\Console\Commands\BotManCacheClear contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Illuminate\Console\GeneratorCommand::getStub) in C:\mychatbot\vendor\botman\studio-addons\src\Console\Commands\BotManCacheClear.php on line 50
Script @php artisan package:discover handling the post-autoload-dump event returned with error code 255`

But if I running this command, composer require botman/stodio-addons "~1.2.1" no errors found (specific version 1.2.1). may be this version (1.4.0) has some bugs. could you please help to fix.

allow PHP 8

Laravel 5.5 - BotManCacheClear.php causing issues.

When using composer install or composer update, I'm getting the issue below:

Class BotMan\Studio\Console\Commands\BotManCacheClear contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Illuminate\Console\GeneratorCommand::getStub)

I've had a look at the BotManCacheClear.php class and found that if you change the class extension from Illuminate\Console\GeneratorCommand to Illuminate\Console\Command it works fine:

class BotManCacheClear extends GeneratorCommand

to:

class BotManCacheClear extends Command

Upgrade to Laravel 6

Compability Laravel 5.7

BotManInstallDriver.php can't connect to internet.

this command after installation of botman studio
php artisan botman:list-drivers

always gives this error:
Unable to fetch BotMan driver repository.
Please check your internet connection ang try again.

and i dont know why.

Packagist has still old v1.4.1

Seems like Packagist has still the old version even though github is on 1.5.0.

ask() method with a string argument can't be tested with assertQuestion

If you ask a question by providing a simple string as a question the assertQuestion fails, but assertReply passes. So it looks like the ask() method produces replies (BotMan\BotMan\Messages\Outgoing\OutgoingMessage) instead of questions (BotMan\BotMan\Messages\Outgoing\Question) if you pass strings to it.

// Conversation 1
$this->ask('How are you?', function (Answer $answer) {
    // ...
});

// Test
$this->bot->assertQuestion('How are you?'); // fails
$this->bot->assertReply('How are you?'); // passes

// Conversation 2
$this->ask(Question::create('How are you?'), function (Answer $answer) {
    // ...
});

// Test
$this->bot->assertQuestion('How are you?'); // passes
$this->bot->assertReply('How are you?'); // fails