bosth / plpygis Goto Github PK

When executing a function defined like below, getting 'cannot import name 'Geometry''
`CREATE OR REPLACE FUNCTION cc_s2sphere_cell_id(pnt geometry)

RETURNS text AS

$$

import s2sphere

from plpygis import Geometry

point = Geometry(pnt)`

I have a pretty simple function that returns a custom type of s2_cell. When calling the function, I get a seg fault on the database and it goes into recovery mode. This used to work, possibly newer versions of debian? Not sure how to proceed in testing. I have manually gone into a python console and not had any issues, but from within plpython3u I get the error. This is on the postgis docker images for FROM postgis/postgis:14-3.1 and also FROM postgis/postgis:13-3.1

`CREATE OR REPLACE FUNCTION public.cc_s2_intersection_cells_at_level(_geom geometry, lvl integer)

RETURNS SETOF s2_cell

LANGUAGE plpython3u

AS $function$

import plpygis

`

Thank you for this useful library.

Currently, in order to get the actual wkb representation of an object, one has to do:

bytes.fromhex(geo.wkb)

It would be both more efficient and more intuitive if geo.wkb contained directly the Well-Known Binary representation of the geometry. The string representation of the wkb could still be obtained with :

geo.wkb.hex()

What do you think about this change ? Would you be opened to a pull request ?

👋 @bosth
First thanks for this great module. We are using it in https://github.com/stac-utils/pgstac and it has been really useful.

One thing we just noticed is that the pypi package contains the .pyc files which are not cross version safe and could lead to some issues.

While working on #1, I found a bug in the existing code: https://github.com/bosth/plpygis/blob/master/plpygis/geometry.py#L194-L195

Reader should be HexReader.

This can be triggered with

Geometry("000000000100000000000000000000000000000000")

which raises

Error
Traceback (most recent call last):
...
  File ".../plpygis/plpygis/geometry.py", line 195, in _from_wkb
    reader = Reader(wkb, ">")  # big-endian reader
NameError: name 'Reader' is not defined