borisbutenko / bp-vuejs-dropdown Goto Github PK

• There are two issues that I'm currently having with this.

1- Firstly I have a list of users and groups, and I want this users sub-dropdown and the groups sub-dropdown to appear above or beyond this screen. You can see this is appearing behind the screen. The z-index on the bp-dropdown_Body is changing nothing.
NOTE - The component with the heading of 'Annotations' and these buttons already has a class with ( position : relative ) in the style.

2- Secondly The mouse hover only works on the first two buttons that is the Home and the Users. I am able to click on the Users button and the Users sub-dropdown will open. but the mouse click doesn't work on the Groups button that is just after the Users, so when the Users sub-dropdown is opened I can only have the mouse click working till the search bar. If I click below it the dropdown will close. Looks like the height is fixed, same way the dropdown closes when you click anywhere on the Groups Button which possibly means that it is considering the mouse to be outside of the dropdown area.

Object doesn't support property or method 'closest' in Dropdown.vue (153, 1)

Seems like this package wasn't transpiled properly or something?

Hi, i noticed that the event listeners are never removed. This can cause memory Leak when Switching Routes.

I think this can be easily solved with something like:

`
...

methods:{

  hide(){
    
    this.isHidden = true
  }

...
},

...
beforeDestroy(){

  $root.$off('bp-dropdown:open', this.hide);
  
  $root.$off('bp-dropdown:hide', this.hide);
}

`

Thanks for the handful component,

regards,

Andrea.

The top level div in Dropdown.vue has a small error in the class binding. Line 2 looks like this:

<div class="bp-dropdown" :class="{ className, 'bp-dropdown--sub': role }">

The problem here is that if className is defined, this results in the div having a literal class named className, for example:

<div class="bp-dropdown className">

whereas the intention was for the class to expand to the value of className. I believe the intention was something like:

<div class="bp-dropdown" :class="{ [className]: className, 'bp-dropdown--sub': role }">

which, assuming className was set to "my-class", would expand to:

<div class="bp-dropdown my-class">

Thanks!