bogdasar1985 / bitziplib Goto Github PK

View Code? Open in Web Editor NEW

6.0 6.0 0.0 244 KB

A library for working with Huffman Code

License: GNU Lesser General Public License v2.1

CMake 0.27% C++ 99.73%

bitziplib's People

Contributors

Stargazers

Watchers

bitziplib's Issues

Guarantee the order of extraction from the `hf_priority_queue`, in any order of addition

Will require you to do this #2

Make two types of function `get_code`

void get_code(const huffman& huf, char sym, char **res)
std::string get_code(const huffman& huf)
These 2 functions should be compiled depending on the compilation flags. (For example -fnostdlib)

Fix compiler warnings

/home/bogdasar/Documents/Programming/C++_Programming/HuffmanCodeLib/hf_priority_queue.cpp: In member function ‘void hf_priority_queue::shiftDown(long int)’:
/home/bogdasar/Documents/Programming/C++_Programming/HuffmanCodeLib/hf_priority_queue.cpp:58:28: warning: comparison of integer expressions of different signedness: ‘long int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
   58 |     while ((2 * index + 1) < _heap.size())
      |            ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
/home/bogdasar/Documents/Programming/C++_Programming/HuffmanCodeLib/hf_priority_queue.cpp:63:19: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
   63 |         if((right < _heap.size()) && (_heap[right] < _heap[left]))
      |             ~~~~~~^~~~~~~~~~~~~~
/home/bogdasar/Documents/Programming/C++_Programming/HuffmanCodeLib/hf_priority_queue.cpp: In member function ‘void hf_priority_queue::shiftDown(long int)’:
/home/bogdasar/Documents/Programming/C++_Programming/HuffmanCodeLib/hf_priority_queue.cpp:58:28: warning: comparison of integer expressions of different signedness: ‘long int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
   58 |     while ((2 * index + 1) < _heap.size())
      |            ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
/home/bogdasar/Documents/Programming/C++_Programming/HuffmanCodeLib/hf_priority_queue.cpp:63:19: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
   63 |         if((right < _heap.size()) && (_heap[right] < _heap[left]))
      |             ~~~~~~^~~~~~~~~~~~~~

Bug in `priority queue` implementation

Separating interface and implementation

Implementation should be write on C++ 98, be open as possible (I mean methods and variables), and could be unsafe(I mean working with memory falls on the user). User also can use methods from this implementation directly, but as a warning, we put all this in namespace called unsafe.
Using this unsafe namespace and aggregation, we will implement a wrapper-interface compatible with Modern C++ since C++11.

Change reserve policy for `dynamic_array`

It's good, when capacity of dynamic_array is power of two, but it rule broke, when we use dynamic_array::reserve(const size_t capacity).
Also, size of template parameter of dynamic_array may not be power of two, we could fix it, by add padding field to them.

Fix warning which happen with `-O2` flag

Fix warnings when compiling with optimization flag level 2 or higher

Add description comments to every function in `huffman.hpp`

Create a documentation

Make a documentation in README.md

Take the `serialization()`/`deserialization()` methods out of the class `hf_priority_queue`

Serialization is not in the area of responsibility of the container class

BIG IMPORTANT BUG!

BUILDING WRONG TREE IN DECODER!
build_tree use huffman implementation of priority_queue with specific policy of sorting, it should use normal policy.

Create a set of examples

Create a set of examples in a separate directory examples

Reimplement `bitset` class

Return wrong code

Mistake in both implementations of `huffman::get_code()`

Not compatible with old decoder from https://github.com/bogdasar1985/HuffmanCode
~~Text decoder to it reverse version~~
UPD: Mistake in method huffman::get_code()

bogdasar1985 / bitziplib Goto Github PK

bitziplib's People

Contributors

Stargazers

Watchers

bitziplib's Issues

Recommend Projects

Recommend Topics

Recommend Org