bocharsky-bw / activemenuitembundle Goto Github PK

View Code? Open in Web Editor NEW

4.0 4.0 5.0 32 KB

The active menu item highlighter of simple HTML menu for Symfony framework

License: MIT License

PHP 80.92% Twig 19.08%

activemenuitembundle's People

Contributors

Stargazers

Watchers

Forkers

beyerjc johnny-bit raistlfiren plusnet-de tchirktema

activemenuitembundle's Issues

Hardcoded active & current class names

Hi!

in method buildClassAttr the active and current classes are hardcoded to active and active current.

ActiveMenuItemBundle/src/BW/ActiveMenuItemBundle/Twig/BWExtension.php

Lines 177 to 185 in 382c5e1

    
           protected function buildClassAttr($isCurrent, $isActive) { 
        
               $result = ''; 
        
               if (true === $isCurrent) { 
        
                   $result = 'current active'; 
        
               } elseif (true === $isActive) { 
        
                   $result = 'active'; 
        
               }

While those are obvious "sane defaults", would be possible to be open for customization? Either in bundle config (not very flexible) or directly in funcion/filter call (quite flexible)

Compatibility with Twig 3.0

Hi there !

The BWExtension currently extends Twig_Extension which is deprecated since Twig 2.7 and was removed in Twig 3.0. Since composer.json does not require twig ^2.10 the extension breaks in newer applications.

There are two possible solutions.

restrict the twig version in the composer.json which is... not ideal i think
or
Change the extend to AbstractExtension and release the bundle in version 2.0

@bocharsky-bw WDYT ?

Deprecation Error - Symfony 4.2 - Configuration TreeBuilder

Hey,

tree builder without root node was deprecated in Symfony 4.2.

"exception" => SilencedErrorContext {#903 ▼
    +count: 2
    -severity: E_USER_DEPRECATED
    trace: {▼
      /var/www/sf4/vendor/symfony/config/Definition/Builder/TreeBuilder.php:30 {▼
        › if (null === $name) {
        ›     @trigger_error('A tree builder without a root node is deprecated since Symfony 4.2 and will not be supported anymore in 5.0.', E_USER_DEPRECATED);
        › } else {
      }
      /var/www/sf4/vendor/bw/active-menu-item-bundle/src/BW/ActiveMenuItemBundle/DependencyInjection/Configuration.php:20 {▼
        › {
        ›     $treeBuilder = new TreeBuilder();
        ›     $rootNode = $treeBuilder->root('bw_active_menu_item');
      }
    }
  }

The Fix could be something like this i think ( i might be wrong :-) )

                $treeBuilder = new TreeBuilder('bw_active_menu_item');
		if (\method_exists($treeBuilder, 'getRootNode')) {
			$rootNode = $treeBuilder->getRootNode();
		} else {
			// BC layer for symfony/config 4.1 and older
			$rootNode = $treeBuilder->root('bw_active_menu_item');
		}

Greetings,
WhiteRabbit

bocharsky-bw / activemenuitembundle Goto Github PK

activemenuitembundle's People

Contributors

Stargazers

Watchers

Forkers

activemenuitembundle's Issues

Hardcoded active & current class names

Compatibility with Twig 3.0

Deprecation Error - Symfony 4.2 - Configuration TreeBuilder

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	protected function buildClassAttr($isCurrent, $isActive) {
	$result = '';

	if (true === $isCurrent) {
	$result = 'current active';
	} elseif (true === $isActive) {
	$result = 'active';
	}