boazsade / rediscpp Goto Github PK

Need to add a git action to verity that we can successfully build the code and test it as well.

Right now we have many types that require passing of a key name, but this is not how it should be, we would like to make it more correct in the sense the that key name is hidden if this is not part of the API.
For example the string type should only contain the string value in the API and the name should not be part of the API, the same is true for the numeric types

It seems that the installation for hiredis (at list on Ubuntu, but maybe on other Linux versions) is not installing the latest version of hiredis.
This means that we would need to build this from source.
There are 3 options:

1. Build this only inside container - but then we would have to depend on it.
2. Have a new target that build hiredis and install it.
3. have hiredis fetched with cmake build and installed.
   option number 3 is problematic in that you have to both build and install hiredis in order for this to work.

currently we are only supporting normal connection without SSL.
This must be change to allow connect with SSL as well

Need to be able to run as async calls.
hiredis is writing incorrectly with callbacks so this is not a great way to work, since this is an antipattern. We need to be able to call these callbaskcs from a correct async framework to support the sync data access.